Haiku/buildtools
1
0
Fork 0
mirror of https://review.haiku-os.org/buildtools synced 2024-11-23 07:18:49 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

jam: Fix build warning. Correct expression.

Browse Source 
Pointer to struct on stack was given instead of the calculated value.

Warning was:

Cc bin.linuxx86/expand.o
expand.c: In function ‘var_expand’:
expand.c:210:49: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘LIST *’ {aka ‘struct _list *’} [-Wformat=]
  210 |       printf("MAXSYM is too low! Need at least %d\n", l);
      |                                                ~^     ~
      |                                                 |     |
      |                                                 int   LIST * {aka struct _list *}

Change-Id: I65ab593287fc1b9aa2aba0056714726e29467012
Reviewed-on: https://review.haiku-os.org/c/buildtools/+/4398
Reviewed-by: John Scipione <jscipione@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
This commit is contained in:
Franck LeCodeur 2021-08-27 20:32:28 +02:00 committed by Jérôme Duval
parent 1673cf9c0f
commit f5c73e1b90
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
jam/expand.c
View File

@ -206,10 +206,14 @@ var_expand(
/* Look for a : modifier in the variable name */ /* Look for a : modifier in the variable name */
/* Must copy into varname so we can modify it */ /* Must copy into varname so we can modify it */
if (strlen(vars->string) > MAXSYM) { size_t varname_len = strlen(vars->string);
printf("MAXSYM is too low! Need at least %d\n", l); if( varname_len > MAXSYM )
exit(-1); {
printf( "MAXSYM is too low! Need at least %zu\n",
varname_len );
exit( -1 );
} }
strcpy( varname, vars->string ); strcpy( varname, vars->string );
if( colon = strchr( varname, MAGIC_COLON ) ) if( colon = strchr( varname, MAGIC_COLON ) )
@ -278,10 +282,12 @@ var_expand(
LIST *rem; LIST *rem;
char *out1; char *out1;
if (out - out_buf > MAXSYM) { if( out - out_buf > MAXSYM )
printf("MAXSYM is too low!\n"); {
exit(-1); printf( "MAXSYM is too low!\n" );
exit( -1 );
} }
/* Handle end subscript (length actually) */ /* Handle end subscript (length actually) */
if( sub2 >= 0 && --sub2 < 0 ) if( sub2 >= 0 && --sub2 < 0 )