Haiku/haiku
Haiku/haiku
1
0
Fork 0
mirror of https://review.haiku-os.org/haiku synced 2025-02-22 13:38:56 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

vm: B_EXECUTE_AREA should not imply B_KERNEL_EXECUTE_AREA.

Browse Source 
Trying to execute user-mapped areas in kernel space should trigger
a fault with SMEP enabled anyway (and we have not seen any thus far.)
This commit is contained in:
Augustin Cavalier 2018-11-17 15:23:55 -05:00
parent d12a2ff55c
commit 04f1a9beae
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/system/kernel/vm/vm.cpp
View File

@ -4915,7 +4915,6 @@ vm_set_area_memory_type(area_id id, phys_addr_t physicalBase, uint32 type)
/*! This function enforces some protection properties:
- if B_WRITE_AREA is set, B_KERNEL_WRITE_AREA is set as well
- if B_EXECUTE_AREA is set, B_KERNEL_EXECUTE_AREA is set as well
- if only B_READ_AREA has been set, B_KERNEL_READ_AREA is also set
- if no protection is specified, it defaults to B_KERNEL_READ_AREA
and B_KERNEL_WRITE_AREA.
@ -4929,8 +4928,6 @@ fix_protection(uint32* protection)
*protection |= B_KERNEL_READ_AREA | B_KERNEL_WRITE_AREA;
else
*protection |= B_KERNEL_READ_AREA;
if ((*protection & B_EXECUTE_AREA) != 0)
*protection |= B_KERNEL_EXECUTE_AREA;
}
}