Haiku/haiku
Haiku/haiku
1
0
Fork 0
mirror of https://review.haiku-os.org/haiku synced 2025-01-18 12:38:51 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

kernel/user_debugger: Add some padding/flexibility to debug_nub_message.

Browse Source 
* Reorder a few messages, and add base numbers so that messages
   can be added in the future to all "sections" without breaking
   previous ABI.

 * Rename some messages for consistency.
This commit is contained in:
Augustin Cavalier 2025-01-13 14:50:03 -05:00
parent bddf466406
commit 43b96dabf2
5 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
headers/os/kernel/debugger.h
View File

@ -167,15 +167,14 @@ typedef enum {
B_DEBUG_MESSAGE_GET_SIGNAL_HANDLER, // a signal
B_DEBUG_MESSAGE_CLONE_AREA, // clone a team area into the debugger team
B_DEBUG_MESSAGE_PREPARE_HANDOVER, // prepares the debugged team for being
B_DEBUG_MESSAGE_PREPARE_HANDOVER = 1000, // prepares the debugged team for being
// handed over to another debugger;
// the new debugger can just invoke
// install_team_debugger()
B_DEBUG_MESSAGE_WRITE_CORE_FILE, // write a core file
B_DEBUG_START_PROFILER, // start/stop sampling
B_DEBUG_STOP_PROFILER, //
B_DEBUG_WRITE_CORE_FILE, // write a core file
B_DEBUG_MESSAGE_START_PROFILER = 2000, // start/stop sampling
B_DEBUG_MESSAGE_STOP_PROFILER, //
} debug_nub_message;
// messages sent to the debugger

2
src/bin/debug/profile/Team.cpp
View File

@ -150,7 +150,7 @@ Team::InitThread(Thread* thread)
debug_nub_start_profiler_reply reply;
status_t error = send_debug_message(&fDebugContext,
B_DEBUG_START_PROFILER, &message, sizeof(message), &reply,
B_DEBUG_MESSAGE_START_PROFILER, &message, sizeof(message), &reply,
sizeof(reply));
if (error != B_OK || (error = reply.error) != B_OK) {
fprintf(stderr,

2
src/kits/debugger/debugger_interface/local/LocalDebuggerInterface.cpp
View File

@ -749,7 +749,7 @@ LocalDebuggerInterface::WriteCoreFile(const char* path)
strlcpy(message.path, path, sizeof(message.path));
status_t error = send_debug_message(contextGetter.Context(),
B_DEBUG_WRITE_CORE_FILE, &message, sizeof(message), &reply,
B_DEBUG_MESSAGE_WRITE_CORE_FILE, &message, sizeof(message), &reply,
sizeof(reply));
if (error == B_OK)
error = reply.error;

2
src/servers/debug/DebugServer.cpp
View File

@ -783,7 +783,7 @@ TeamDebugHandler::_WriteCoreFile()
debug_nub_write_core_file_reply reply;
error = send_debug_message(&fDebugContext, B_DEBUG_WRITE_CORE_FILE,
error = send_debug_message(&fDebugContext, B_DEBUG_MESSAGE_WRITE_CORE_FILE,
&message, sizeof(message), &reply, sizeof(reply));
if (error == B_OK)
error = reply.error;

6
src/system/kernel/debug/user_debugger.cpp
View File

@ -2345,7 +2345,7 @@ debug_nub_thread(void *)
break;
}
case B_DEBUG_START_PROFILER:
case B_DEBUG_MESSAGE_START_PROFILER:
{
// get the parameters
thread_id threadID = message.start_profiler.thread;
@ -2457,7 +2457,7 @@ debug_nub_thread(void *)
break;
}
case B_DEBUG_STOP_PROFILER:
case B_DEBUG_MESSAGE_STOP_PROFILER:
{
// get the parameters
thread_id threadID = message.stop_profiler.thread;
@ -2539,7 +2539,7 @@ debug_nub_thread(void *)
break;
}
case B_DEBUG_WRITE_CORE_FILE:
case B_DEBUG_MESSAGE_WRITE_CORE_FILE:
{
// get the parameters
replyPort = message.write_core_file.reply_port;