From 7b661b559ebc6e16fb912c4601cc62b81d10923f Mon Sep 17 00:00:00 2001
From: Adrien Destugues <adrien.destugues@opensource.viveris.fr>
Date: Sun, 10 Jan 2021 18:07:21 +0100
Subject: [PATCH] BSecureSocket: fix read error handling
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The current documentation
(https://www.openssl.org/docs/man1.1.1/man3/SSL_read.html) says that
SSL_read returning 0 should be handled as an error. So, let's do that.

Change-Id: I6781826ea700b6e597fd2d444fd96a1a5270c6cf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3620
Reviewed-by: Stephan Aßmus <superstippi@gmx.de>
---
 src/kits/network/libnetapi/SecureSocket.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kits/network/libnetapi/SecureSocket.cpp b/src/kits/network/libnetapi/SecureSocket.cpp
index d8bb5eeecb..399b213f73 100644
--- a/src/kits/network/libnetapi/SecureSocket.cpp
+++ b/src/kits/network/libnetapi/SecureSocket.cpp
@@ -540,7 +540,7 @@ BSecureSocket::Read(void* buffer, size_t size)
 	int retry;
 	do {
 		bytesRead = SSL_read(fPrivate->fSSL, buffer, size);
-		if (bytesRead >= 0)
+		if (bytesRead > 0)
 			return bytesRead;
 
 		if (errno != EINTR) {