Haiku/haiku
Haiku/haiku
1
0
Fork 0
mirror of https://review.haiku-os.org/haiku synced 2025-02-22 21:48:35 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

* fix some invalidation problems with the triangle thumb which are caused by

Browse Source 
non-traight lines extending past the thumb frame because of anti-aliasing
  effects


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23286 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stephan Aßmus 2008-01-08 18:56:04 +00:00
parent 01c2f44ee8
commit 7b94dab18f
1 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/kits/interface/Slider.cpp
View File

@ -615,15 +615,6 @@ BSlider::SetValue(int32 value)
BRect oldThumbFrame = ThumbFrame();
if (IsFocus() && Style() == B_TRIANGLE_THUMB) {
// we need to update the region with the focus mark as well
// (a method BSlider::FocusMarkFrame() would be nice as well)
if (fOrientation == B_HORIZONTAL)
oldThumbFrame.bottom += 2;
else
oldThumbFrame.left -= 2;
}
// While it would be enough to do this dependent on fUseFillColor,
// that doesn't work out if DrawBar() has been overridden by a sub class
if (fOrientation == B_HORIZONTAL)
@ -634,7 +625,25 @@ BSlider::SetValue(int32 value)
_SetLocation(loc);
BControl::SetValueNoUpdate(value);
Invalidate(oldThumbFrame | ThumbFrame());
BRect invalid = oldThumbFrame | ThumbFrame();
if (Style() == B_TRIANGLE_THUMB) {
// 1) we need to take care of pixels touched because of
// anti-aliasing
// 2) we need to update the region with the focus mark as well
// (a method BSlider::FocusMarkFrame() would be nice as well)
if (fOrientation == B_HORIZONTAL) {
if (IsFocus())
invalid.bottom += 2;
invalid.InsetBy(-1, 0);
} else {
if (IsFocus())
invalid.left -= 2;
invalid.InsetBy(0, -1);
}
}
Invalidate(invalid);
// update text label