From 84bff7524538da9da3fbefc8e811b09042a52566 Mon Sep 17 00:00:00 2001 From: John Scipione Date: Sat, 1 Mar 2014 13:16:10 -0500 Subject: [PATCH] GIFTranslator: Log info messages with LOG_INFO not LOG_ERR --- src/add-ons/translators/gif/GIFLoad.cpp | 28 ++++++++-------- src/add-ons/translators/gif/GIFSave.cpp | 33 ++++++++++--------- src/add-ons/translators/gif/GIFTranslator.cpp | 2 +- 3 files changed, 32 insertions(+), 31 deletions(-) diff --git a/src/add-ons/translators/gif/GIFLoad.cpp b/src/add-ons/translators/gif/GIFLoad.cpp index 1abe69551d..2ae54aef35 100644 --- a/src/add-ons/translators/gif/GIFLoad.cpp +++ b/src/add-ons/translators/gif/GIFLoad.cpp @@ -47,7 +47,7 @@ GIFLoad::GIFLoad(BPositionIO* input, BPositionIO* output) } if (debug) { - syslog(LOG_ERR, "GIFLoad::GIFLoad() - Image dimensions are %d x %d\n", + syslog(LOG_INFO, "GIFLoad::GIFLoad() - Image dimensions are %d x %d\n", fWidth, fHeight); } @@ -68,7 +68,7 @@ GIFLoad::GIFLoad(BPositionIO* input, BPositionIO* output) fatalerror = true; } else { if (debug) { - syslog(LOG_ERR, "GIFLoad::GIFLoad() - " + syslog(LOG_INFO, "GIFLoad::GIFLoad() - " "Found a single image and leaving\n"); } } @@ -116,7 +116,7 @@ GIFLoad::GIFLoad(BPositionIO* input, BPositionIO* output) } if (debug) - syslog(LOG_ERR, "GIFLoad::GIFLoad() - Done\n"); + syslog(LOG_INFO, "GIFLoad::GIFLoad() - Done\n"); } @@ -142,7 +142,7 @@ GIFLoad::ReadGIFHeader() if (header[10] & GIF_LOCALCOLORMAP) { fPalette->size_in_bits = (header[10] & 0x07) + 1; if (debug) { - syslog(LOG_ERR, "GIFLoad::ReadGIFHeader() - " + syslog(LOG_INFO, "GIFLoad::ReadGIFHeader() - " "Found %d bit global palette\n", fPalette->size_in_bits); } @@ -200,7 +200,7 @@ GIFLoad::ReadGIFControlBlock() fPalette->usetransparent = true; fPalette->transparentindex = data[4]; if (debug) { - syslog(LOG_ERR, "GIFLoad::ReadGIFControlBlock() - " + syslog(LOG_INFO, "GIFLoad::ReadGIFControlBlock() - " "Transparency active, using palette index %d\n", data[4]); } } @@ -213,7 +213,7 @@ bool GIFLoad::ReadGIFCommentBlock() { if (debug) - syslog(LOG_ERR, "GIFLoad::ReadGIFCommentBlock() - Found:\n"); + syslog(LOG_INFO, "GIFLoad::ReadGIFCommentBlock() - Found:\n"); unsigned char length; char comment_data[256]; @@ -226,11 +226,11 @@ GIFLoad::ReadGIFCommentBlock() comment_data[length] = 0x00; if (debug) - syslog(LOG_ERR, "%s", comment_data); + syslog(LOG_INFO, "%s", comment_data); } while (length != 0x00); if (debug) - syslog(LOG_ERR, "\n"); + syslog(LOG_INFO, "\n"); return true; } @@ -240,7 +240,7 @@ bool GIFLoad::ReadGIFUnknownBlock(unsigned char c) { if (debug) - syslog(LOG_ERR, "GIFLoad::ReadGIFUnknownBlock() - Found: %d\n", c); + syslog(LOG_INFO, "GIFLoad::ReadGIFUnknownBlock() - Found: %d\n", c); unsigned char length; do { @@ -301,7 +301,7 @@ GIFLoad::ReadGIFImageHeader() int s = 1 << fPalette->size_in_bits; fPalette->size = s; if (debug) { - syslog(LOG_ERR, "GIFLoad::ReadGIFImageHeader() - " + syslog(LOG_INFO, "GIFLoad::ReadGIFImageHeader() - " "Found %d bit local palette\n", fPalette->size_in_bits); } @@ -316,10 +316,10 @@ GIFLoad::ReadGIFImageHeader() fInterlaced = data[8] & GIF_INTERLACED; if (debug) { if (fInterlaced) { - syslog(LOG_ERR, "GIFLoad::ReadGIFImageHeader() - " + syslog(LOG_INFO, "GIFLoad::ReadGIFImageHeader() - " "Image is interlaced\n"); } else { - syslog(LOG_ERR, "GIFLoad::ReadGIFImageHeader() - " + syslog(LOG_INFO, "GIFLoad::ReadGIFImageHeader() - " "Image is not interlaced\n"); } } @@ -355,7 +355,7 @@ GIFLoad::ReadGIFImageData() } if (debug) - syslog(LOG_ERR, "GIFLoad::ReadGIFImageData() - Starting LZW\n"); + syslog(LOG_INFO, "GIFLoad::ReadGIFImageData() - Starting LZW\n"); while ((fNewCode = NextCode()) != -1 && fNewCode != fEndCode) { if (fNewCode == fClearCode) { @@ -439,7 +439,7 @@ GIFLoad::ReadGIFImageData() return false; if (debug) - syslog(LOG_ERR, "GIFLoad::ReadGIFImageData() - Done\n"); + syslog(LOG_INFO, "GIFLoad::ReadGIFImageData() - Done\n"); return true; diff --git a/src/add-ons/translators/gif/GIFSave.cpp b/src/add-ons/translators/gif/GIFSave.cpp index 7805bb69ba..5cb923c100 100644 --- a/src/add-ons/translators/gif/GIFSave.cpp +++ b/src/add-ons/translators/gif/GIFSave.cpp @@ -69,13 +69,13 @@ GIFSave::GIFSave(BBitmap* bitmap, BPositionIO* output, width = bitmap->Bounds().IntegerWidth() + 1; height = bitmap->Bounds().IntegerHeight() + 1; if (debug) { - syslog(LOG_ERR, "GIFSave::GIFSave() - " + syslog(LOG_INFO, "GIFSave::GIFSave() - " "Image dimensions are %d by %d\n", width, height); } if (fSettings->SetGetBool(GIF_SETTING_USE_DITHERING)) { if (debug) - syslog(LOG_ERR, "GIFSave::GIFSave() - Using dithering\n"); + syslog(LOG_INFO, "GIFSave::GIFSave() - Using dithering\n"); red_error = new int32[width + 2]; red_error = &red_error[1]; @@ -94,26 +94,27 @@ GIFSave::GIFSave(BBitmap* bitmap, BPositionIO* output, blue_error[x] = 0; } } else if (debug) - syslog(LOG_ERR, "GIFSave::GIFSave() - Not using dithering\n"); + syslog(LOG_INFO, "GIFSave::GIFSave() - Not using dithering\n"); if (debug) { if (fSettings->SetGetBool(GIF_SETTING_INTERLACED)) - syslog(LOG_ERR, "GIFSave::GIFSave() - Interlaced, "); + syslog(LOG_INFO, "GIFSave::GIFSave() - Interlaced, "); else - syslog(LOG_ERR, "GIFSave::GIFSave() - Not interlaced, "); + syslog(LOG_INFO, "GIFSave::GIFSave() - Not interlaced, "); + switch (fSettings->SetGetInt32(GIF_SETTING_PALETTE_MODE)) { case WEB_SAFE_PALETTE: - syslog(LOG_ERR, "web safe palette\n"); + syslog(LOG_INFO, "web safe palette\n"); break; case BEOS_SYSTEM_PALETTE: - syslog(LOG_ERR, "BeOS system palette\n"); + syslog(LOG_INFO, "BeOS system palette\n"); break; case GREYSCALE_PALETTE: - syslog(LOG_ERR, "greyscale palette\n"); + syslog(LOG_INFO, "greyscale palette\n"); break; case OPTIMAL_PALETTE: default: - syslog(LOG_ERR, "optimal palette\n"); + syslog(LOG_INFO, "optimal palette\n"); break; } } @@ -122,7 +123,7 @@ GIFSave::GIFSave(BBitmap* bitmap, BPositionIO* output, if (fSettings->SetGetBool(GIF_SETTING_USE_TRANSPARENT_AUTO)) { palette->PrepareForAutoTransparency(); if (debug) { - syslog(LOG_ERR, "GIFSave::GIFSave() - " + syslog(LOG_INFO, "GIFSave::GIFSave() - " "Using transparent index %d\n", palette->TransparentIndex()); } @@ -132,7 +133,7 @@ GIFSave::GIFSave(BBitmap* bitmap, BPositionIO* output, (uint8)fSettings->SetGetInt32(GIF_SETTING_TRANSPARENT_GREEN), (uint8)fSettings->SetGetInt32(GIF_SETTING_TRANSPARENT_BLUE)); if (debug) { - syslog(LOG_ERR, "GIFSave::GIFSave() - " + syslog(LOG_INFO, "GIFSave::GIFSave() - " "Found transparent color %d,%d,%d at index %d\n", fSettings->SetGetInt32(GIF_SETTING_TRANSPARENT_RED), fSettings->SetGetInt32(GIF_SETTING_TRANSPARENT_GREEN), @@ -142,27 +143,27 @@ GIFSave::GIFSave(BBitmap* bitmap, BPositionIO* output, } } else { if (debug) - syslog(LOG_ERR, "GIFSave::GIFSave() - Not using transparency\n"); + syslog(LOG_INFO, "GIFSave::GIFSave() - Not using transparency\n"); } this->output = output; this->bitmap = bitmap; WriteGIFHeader(); if (debug) - syslog(LOG_ERR, "GIFSave::GIFSave() - Wrote gif header\n"); + syslog(LOG_INFO, "GIFSave::GIFSave() - Wrote gif header\n"); hash = new SFHash(1 << 16); WriteGIFControlBlock(); if (debug) - syslog(LOG_ERR, "GIFSave::GIFSave() - Wrote gif control block\n"); + syslog(LOG_INFO, "GIFSave::GIFSave() - Wrote gif control block\n"); WriteGIFImageHeader(); if (debug) - syslog(LOG_ERR, "GIFSave::GIFSave() - Wrote gif image header\n"); + syslog(LOG_INFO, "GIFSave::GIFSave() - Wrote gif image header\n"); WriteGIFImageData(); if (debug) - syslog(LOG_ERR, "GIFSave::GIFSave() - Wrote gif image data\n"); + syslog(LOG_INFO, "GIFSave::GIFSave() - Wrote gif image data\n"); if (fSettings->SetGetBool(GIF_SETTING_USE_DITHERING)) { delete[] &red_error[-1]; diff --git a/src/add-ons/translators/gif/GIFTranslator.cpp b/src/add-ons/translators/gif/GIFTranslator.cpp index a496be656d..9a931d7413 100644 --- a/src/add-ons/translators/gif/GIFTranslator.cpp +++ b/src/add-ons/translators/gif/GIFTranslator.cpp @@ -285,7 +285,7 @@ GIFTranslator::DerivedTranslate(BPositionIO* inSource, if (debug) { now = system_time() - now; - syslog(LOG_ERR, "Translate() - Translation took %Ld microseconds\n", + syslog(LOG_INFO, "Translate() - Translation took %Ld microseconds\n", now); } return B_OK;