From ae6629023fb03bf965b25930ebdb9c83a06af592 Mon Sep 17 00:00:00 2001
From: Augustin Cavalier <waddlesplash@gmail.com>
Date: Fri, 6 Dec 2024 17:12:56 -0500
Subject: [PATCH] tests/kernel/vm: Add mmap_invalid_tests.

Move one test from map_cut_tests, otherwise the other tests are new.
Includes a test for the cause of #19155.

Change-Id: I15abbf11f2c6db7385754825abbcc159414f6fd8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8631
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
---
 src/tests/system/kernel/vm/Jamfile            |   1 +
 src/tests/system/kernel/vm/mmap_cut_tests.cpp |  16 ---
 .../system/kernel/vm/mmap_invalid_tests.cpp   | 112 ++++++++++++++++++
 3 files changed, 113 insertions(+), 16 deletions(-)
 create mode 100644 src/tests/system/kernel/vm/mmap_invalid_tests.cpp

diff --git a/src/tests/system/kernel/vm/Jamfile b/src/tests/system/kernel/vm/Jamfile
index 9513ae3b39..f3671189d2 100644
--- a/src/tests/system/kernel/vm/Jamfile
+++ b/src/tests/system/kernel/vm/Jamfile
@@ -8,6 +8,7 @@ SimpleTest page_fault_cache_merge_test : page_fault_cache_merge_test.cpp ;
 
 SimpleTest mmap_resize_test : mmap_resize_test.cpp ;
 SimpleTest mmap_cut_tests : mmap_cut_tests.cpp ;
+SimpleTest mmap_invalid_tests : mmap_invalid_tests.cpp ;
 SimpleTest mmap_fixed_test : mmap_fixed_test.cpp ;
 
 SimpleTest reserved_areas_test : reserved_areas_test.cpp ;
diff --git a/src/tests/system/kernel/vm/mmap_cut_tests.cpp b/src/tests/system/kernel/vm/mmap_cut_tests.cpp
index 61e2bcbc0c..671f3e70a3 100644
--- a/src/tests/system/kernel/vm/mmap_cut_tests.cpp
+++ b/src/tests/system/kernel/vm/mmap_cut_tests.cpp
@@ -15,19 +15,6 @@
 int gTestFd = -1;
 
 
-int
-map_negative_offset_test()
-{
-	// should fail (negative offset)
-	void* ptr = mmap(NULL, B_PAGE_SIZE, PROT_READ, MAP_PRIVATE, gTestFd, -4096);
-	if (ptr != MAP_FAILED) {
-		printf("map-negative-offset unexpectedly succeeded!\n");
-		return -1;
-	}
-	return 0;
-}
-
-
 int
 map_cut_compare_test()
 {
@@ -207,9 +194,6 @@ main()
 
 	int status;
 
-	if ((status = map_negative_offset_test()) != 0)
-		return status;
-
 	if ((status = map_cut_compare_test()) != 0)
 		return status;
 
diff --git a/src/tests/system/kernel/vm/mmap_invalid_tests.cpp b/src/tests/system/kernel/vm/mmap_invalid_tests.cpp
new file mode 100644
index 0000000000..8c76e3d665
--- /dev/null
+++ b/src/tests/system/kernel/vm/mmap_invalid_tests.cpp
@@ -0,0 +1,112 @@
+/*
+ * Copyright 2024, Haiku, Inc. All rights reserved.
+ * Distributed under the terms of the MIT License.
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <sys/mman.h>
+#include <unistd.h>
+#include <OS.h>
+
+
+static int gTestFD = -1;
+static const size_t kFileSize = B_PAGE_SIZE * 2 + (B_PAGE_SIZE / 2);
+
+
+int
+map_negative_offset_test()
+{
+	// should fail (negative offset)
+	void* ptr = mmap(NULL, B_PAGE_SIZE, PROT_READ, MAP_PRIVATE, gTestFD, -4096);
+	if (ptr != MAP_FAILED) {
+		printf("map-negative-offset unexpectedly succeeded!\n");
+		return -1;
+	}
+	return 0;
+}
+
+
+int
+resize_mapping_test()
+{
+	void* ptr = mmap(NULL, B_PAGE_SIZE, PROT_READ, MAP_SHARED, gTestFD, 0);
+	if (ptr == MAP_FAILED)
+		return -1;
+
+	area_id area = area_for(ptr);
+	if (area < B_OK)
+		return -1;
+
+	// should fail (not allowed to resize)
+	if (resize_area(area, B_PAGE_SIZE * 2) == B_OK) {
+		printf("resize area unexpectedly succeeded!\n");
+		return -1;
+	}
+
+	if (delete_area(area) != B_OK)
+		return -1;
+	return 0;
+}
+
+
+int
+map_past_end_test()
+{
+	void* ptr = mmap(NULL, B_PAGE_SIZE, PROT_READ, MAP_PRIVATE, gTestFD, B_PAGE_SIZE * 4);
+	if (ptr != MAP_FAILED) {
+		printf("map-past end 1 unexpectedly succeeded!\n");
+		return -1;
+	}
+
+	ptr = mmap(NULL, B_PAGE_SIZE, PROT_READ, MAP_SHARED, gTestFD, B_PAGE_SIZE * 4);
+	if (ptr != MAP_FAILED) {
+		printf("map-past end 2 unexpectedly succeeded!\n");
+		return -1;
+	}
+	return 0;
+}
+
+
+int
+main()
+{
+	const char* fileName = "/tmp/mmap-invalid-test-file";
+
+	// create file
+	gTestFD = open(fileName, O_CREAT | O_RDWR | O_TRUNC, 0644);
+	if (gTestFD < 0) {
+		fprintf(stderr, "Failed to open \"%s\": %s\n", fileName,
+			strerror(errno));
+		return 1;
+	}
+
+	// write pages
+	char buffer[2048];
+	memset(buffer, 0xdd, sizeof(buffer));
+	size_t written = 0;
+	while (written < kFileSize) {
+		if (write(gTestFD, buffer, sizeof(buffer)) != (ssize_t)sizeof(buffer)) {
+			fprintf(stderr, "Failed to write to file!\n");
+			return 1;
+		}
+		written += sizeof(buffer);
+	}
+
+	int status;
+
+	if ((status = map_negative_offset_test()) != 0)
+		return status;
+
+	if ((status = resize_mapping_test()) != 0)
+		return status;
+
+	if ((status = map_past_end_test()) != 0)
+		return status;
+
+	unlink(fileName);
+	return 0;
+}