From b5fae382545caad6531ea60477d34d6783188b7d Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Mon, 13 Jun 2022 20:24:17 -0400 Subject: [PATCH] network/ethernet: Do not set IFM_ETHER in update_link_state. All the drivers that support ETHER_GET_LINK_STATE set this correctly; and more specifically, it should actually not be set on some devices (WiFi devices, specifically). Since SIOCGIFMEDIA has always been passed through directly to the driver if it supports it, WiFi devices worked anyway because this value never made it to userland. That will soon change, hence this needed to be fixed. --- src/add-ons/kernel/network/devices/ethernet/ethernet.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/add-ons/kernel/network/devices/ethernet/ethernet.cpp b/src/add-ons/kernel/network/devices/ethernet/ethernet.cpp index e6327194bd..425567ea7a 100644 --- a/src/add-ons/kernel/network/devices/ethernet/ethernet.cpp +++ b/src/add-ons/kernel/network/devices/ethernet/ethernet.cpp @@ -66,9 +66,6 @@ update_link_state(ethernet_device *device, bool notify = true) return B_NOT_SUPPORTED; } - state.media |= IFM_ETHER; - // make sure the media type is returned correctly - if (device->media != state.media || device->link_quality != state.quality || device->link_speed != state.speed) {