Haiku/haiku
Haiku/haiku
1
0
Fork 0
mirror of https://review.haiku-os.org/haiku synced 2025-01-21 22:04:49 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

XHCI: Do not set "Interrupt Short Packet" on transfers.

Browse Source 
Before the refactor to use Event Data TRBs, this was necessary
to detect short packet conditions. Now that we use Event Data
TRBs, the hardware will send us an Event Data event even on
Short Packet conditions, so this is redundant.

Fixes log spam of "TRB ... not found in the endpoint", as
this was causing duplicate event postings. Also potentially
fixes instability seen when those messages were present.
This commit is contained in:
Augustin Cavalier 2020-02-08 13:36:51 -05:00
parent 78b224583c
commit b8852a24a6
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/add-ons/kernel/busses/usb/xhci.cpp
View File

@ -739,7 +739,7 @@ XHCI::SubmitControlRequest(Transfer *transfer)
| TRB_2_BYTES(requestData->Length)
| TRB_2_TD_SIZE(0);
descriptor->trbs[index].flags = TRB_3_TYPE(TRB_TYPE_DATA_STAGE)
| (directionIn ? (TRB_3_DIR_IN | TRB_3_ISP_BIT) : 0)
| (directionIn ? TRB_3_DIR_IN : 0)
| TRB_3_CYCLE_BIT;
if (!directionIn) {
@ -832,8 +832,7 @@ XHCI::SubmitNormalRequest(Transfer *transfer)
| TRB_2_BYTES(trbLength)
| TRB_2_TD_SIZE(tdSize);
td->trbs[i].flags = TRB_3_TYPE(TRB_TYPE_NORMAL)
| TRB_3_CYCLE_BIT | TRB_3_CHAIN_BIT
| (directionIn ? TRB_3_ISP_BIT : 0);
| TRB_3_CYCLE_BIT | TRB_3_CHAIN_BIT;
td->trb_used++;
remaining -= trbLength;