Haiku/haiku
Haiku/haiku
1
0
Fork 0
mirror of https://review.haiku-os.org/haiku synced 2025-01-18 12:38:51 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

kernel/user_debugger: Add some more permissions checks.

Browse Source 
Only root, teams of the same UID, or the actually installed
debugger team can remove a team debugger or debug a thread.
This commit is contained in:
Augustin Cavalier 2025-01-13 14:47:23 -05:00
parent 0dd81e3d4b
commit bddf466406
1 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/system/kernel/debug/user_debugger.cpp
View File

@ -2989,23 +2989,31 @@ _user_remove_team_debugger(team_id teamID)
Team* team;
ConditionVariable debugChangeCondition;
debugChangeCondition.Init(NULL, "debug change condition");
status_t error = prepare_debugger_change(teamID, debugChangeCondition,
status_t status = prepare_debugger_change(teamID, debugChangeCondition,
team);
if (error != B_OK)
return error;
if (status != B_OK)
return status;
InterruptsSpinLocker debugInfoLocker(team->debug_info.lock);
thread_id nubThread = -1;
port_id nubPort = -1;
if (team->debug_info.flags & B_TEAM_DEBUG_DEBUGGER_INSTALLED) {
// there's a debugger installed
if ((team->debug_info.flags & B_TEAM_DEBUG_DEBUGGER_INSTALLED) == 0) {
// no debugger installed
status = B_BAD_VALUE;
}
if (status == B_OK) {
if (geteuid() != 0 && team->effective_uid != geteuid()
&& team->debug_info.debugger_team != team_get_current_team_id())
status = B_PERMISSION_DENIED;
}
if (status == B_OK) {
// there's a debugger installed, and we're allowed to remove it
nubThread = team->debug_info.nub_thread;
nubPort = team->debug_info.nub_port;
} else {
// no debugger installed
error = B_BAD_VALUE;
}
debugInfoLocker.Unlock();
@ -3021,7 +3029,7 @@ _user_remove_team_debugger(team_id teamID)
if (nubThread >= 0)
wait_for_thread(nubThread, NULL);
return error;
return status;
}
@ -3042,6 +3050,10 @@ _user_debug_thread(thread_id threadID)
if (thread->team == team_get_kernel_team())
return B_NOT_ALLOWED;
if (geteuid() != 0 && thread->team->effective_uid != geteuid()
&& thread->team->debug_info.debugger_team != team_get_current_team_id())
return B_PERMISSION_DENIED;
InterruptsLocker interruptsLocker;
SpinLocker threadDebugInfoLocker(thread->debug_info.lock);