Haiku/haiku
Haiku/haiku
1
0
Fork 0
mirror of https://review.haiku-os.org/haiku synced 2025-02-07 14:25:58 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "Add-ons: Add alert warning to PNGTranslator"

Browse Source 
This reverts commit 450208975b6a059e645e8c2b4a77c346b9b03b71.

The alert is not appropriate because applications cannot intercept it.

Fixes #15734

Change-Id: I5be98367ae615a572193406a559e5d34617e445c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2626
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit fc86ef2cef7b440577edddbd6db02399a423a1d6)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2632
This commit is contained in:
Adrien Destugues 2020-05-09 15:11:16 +02:00 committed by waddlesplash
parent aefa31ac26
commit cd75621a52
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/add-ons/translators/png/PNGTranslator.cpp
View File

@ -36,7 +36,6 @@
#include <stdio.h>
#include <string.h>
#include <Alert.h>
#include <Catalog.h>
#include <OS.h>
#define PNG_NO_PEDANTIC_WARNINGS
@ -300,11 +299,9 @@ void throw_error(png_structp ppng, png_const_charp error_msg)
void alert_warning(png_structp ppng, png_const_charp error_msg)
{
BAlert* alert = new BAlert("alert", error_msg,
B_TRANSLATE("OK"), NULL, NULL, B_WIDTH_FROM_LABEL,
B_WARNING_ALERT);
alert->SetFlags(alert->Flags() | B_CLOSE_ON_ESCAPE);
alert->Go();
// These are only warnings and the image can still be decoded. We have no
// way to convey this to the calling app using the current translator API,
// so the warnings are just ignored.
}
status_t