Haiku/haiku
Haiku/haiku
1
0
Fork 0
mirror of https://review.haiku-os.org/haiku synced 2025-02-23 05:58:31 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tracker: Store the correct time value in the thumbnail creation attribute.

Browse Source 
We were storing real_time_clock_usecs() but comparing against
BStatable::GetModificationTime() which is just a time_t. The
values were thus displayed wrongly in the "Get Info" window,
but also thumbnails would not have been updated when the file was.

Should fix #18691 and possibly some other tickets.
This commit is contained in:
Augustin Cavalier 2023-11-30 17:42:08 -05:00
parent b6c24e6b40
commit f7fb846f5b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/kits/tracker/Thumbnails.cpp
View File

@ -224,9 +224,9 @@ GenerateThumbnailJob::Execute()
thumbnailWritten = (status == B_OK);
// write thumbnail creation time into an attribute
bigtime_t created = real_time_clock_usecs();
int64_t created = real_time_clock();
fFile->WriteAttr(kAttrThumbnailCreationTime, B_TIME_TYPE,
0, &created, sizeof(bigtime_t));
0, &created, sizeof(int64_t));
}
}
@ -347,11 +347,11 @@ GetThumbnailFromAttr(Model* model, BBitmap* icon, BSize size)
// look for a thumbnail in an attribute
time_t modtime;
bigtime_t created;
int64_t thumbnailCreated;
if (node->GetModificationTime(&modtime) == B_OK
&& node->ReadAttr(kAttrThumbnailCreationTime, B_TIME_TYPE, 0,
&created, sizeof(bigtime_t)) == sizeof(bigtime_t)) {
if (created > (bigtime_t)modtime) {
&thumbnailCreated, sizeof(int64_t)) == sizeof(int64_t)) {
if (thumbnailCreated > modtime) {
// file has not changed, try to return an existing thumbnail
attr_info attrInfo;
if (node->GetAttrInfo(kAttrThumbnail, &attrInfo) == B_OK) {