TableCellTextControlEditor:
- Serves as a base for editors that expose their functionality via a
text control. Handles common functionality of watching for changes,
validating input, and notifying listeners appropriately.
TableCellOptionPopUpEditor:
- Serves as a base class for editors where the set of possible values
is fixed and known up front. Handles reacting to selection changes
and notifying listeners.
- Introduce interface class ValueFormatter. This one takes on the
responsibilities of formatting a value into a string, which were
previously embedded within the various TableCellValueRenderer
subclasses.
- Add implementing subclasses for the various value types.
- Introduce TableCellValueRenderer subclass TableCellFormattedValueRenderer.
This is a simple TableCellValueRenderer implementation for the simple case
of a renderer that does nothing more than use a formatter to present a
string version of its corresponding Value. Since this describes all existing
renderers, this renders them obsolete.
- Refactor the respective ValueHandler subclasses to make use of the formatters
and new rendererer subclass.
- Add new interface class TableCellValueEditor, which provides a controller
for handling editing of table cell values, and corresponding listener
notifications.
ValueHandler:
- Add new hook for requesting such an editor, given a corresponding
value.
This was fixed in 2008 in the ide_pci driver, but has never been merged
in ide_isa. It probably won't matter as machine with IDE on the ISA bus
are unlikely to run Haiku.
Thanks to philcostin for finding the problem using cppcheck.
The C code would crash on my machine, and using std::list is simpler and
cleaner.
May help with #11895 as well, but I didn't have that issue on my
machine.
* This also updates /etc/profile to detect whether our
parent process is a shell, and changes the banner
message accordingly.
* Also, pipe errors to /dev/null, in case grep is not
installed; this allows us to not require grep as a
dependency, and let the banner message do the right
thing.
* Icon-O-Matic and Cortex are dependent on the feature.
* remove expat lib from the build and from the tree.
* expat package is added to regular builds.
... from "Use this time" to "Keep this time", as the question is about
keeping the status quo, not changing to some different time.
As discussed with Humdinger in #haiku.
* The insertion index didn't take into account the fact
that some paths don't get added before the index is
calculated. This resulted in the requested arch paths
ending up in reverse if we were already in the
requested arch environment.
Fixes #12125.
* This would be a GPT partition pointing to itself, leading to infinite
recursion in the GPT parser calling itself and Haiku would reset
(probably triple fault?).
* Thanks to Puck for discovering this!
- Remove out-of-place accessor to type lookup info on ValueLoader.
Instead, adjust CreateChildren() and CreateChildrenInRange() to take a
TeamTypeInformation parameter. This can then be used by value nodes that
need to be able to look up type information in order to properly
publish their children, such as BList and BMessage. Refactor subclasses
and callers accordingly
MemoryView:
- During edit mode, if navigating with the left or right arrow
only resulted adjusting the focus nybble and not transitioning
to another block, redraw wouldn't be triggered, leading to it appearing
as if the keypress had no effect.
Currently, Haiku has two mimetypes for MIDI files, which causes the
logic for clearing the currently marked item to sometimes fail. Instead,
when two mimetypes have the same description, the subtype is added to
the label in parentheses as is done in the FileTypes preflet.
