6155 Commits

Author SHA1 Message Date
John Scipione
bec7990562 Remove yet another unneeded include 2013-04-14 02:49:34 -04:00
John Scipione
5d6f247bb3 Reverse loop to eliminate checking count each iteration 2013-04-14 02:49:34 -04:00
John Scipione
9439677a9c Check if icon size is the same, if so, don't resize 2013-04-14 02:49:34 -04:00
John Scipione
ee78e4de9f Convert state variable from a uint32 to an int32 2013-04-14 02:49:32 -04:00
John Scipione
2de4b0463f Remove unneeded includes from BarView 2013-04-14 02:49:30 -04:00
John Scipione
b54536b20d Don't need to check if Lock() succeeded here, I don't anywhere else. 2013-04-14 02:49:30 -04:00
John Scipione
fe624b3937 Style fixes only
Most indentation and newlines with a few comment updates
2013-04-14 02:49:29 -04:00
John Scipione
10a5b6946c Remove unneeded includes 2013-04-14 02:49:29 -04:00
Alexander von Gluck IV
1f4fe8a48a MusicCollection: Fix build
* Include Debug.h for printf
2013-04-14 06:00:53 +00:00
Rene Gollent
f21f5c7cee Fix build. 2013-04-13 17:46:48 -04:00
Rene Gollent
692d2db52a Notify user if the we fail to parse the type. 2013-04-13 17:25:52 -04:00
Rene Gollent
8598af7ec9 Rework parsing a bit to handle some cases better.
Disable array parsing for now until creating array types works correctly.
2013-04-13 17:25:51 -04:00
Rene Gollent
2dc96a685d Add support for specifying array delimiters.
- Extend CppLanguage::ParseTypeExpression() to also grok array
specifiers. This theoretically lets one now typecast to array types
as well as pointer types, though things don't entirely work as expected
yet.
2013-04-12 23:35:42 -04:00
Rene Gollent
d18be78af7 Implement DwarfType::CreateDerivedArrayType().
Will be used for array typecasting.
2013-04-12 23:35:41 -04:00
Rene Gollent
8db1d0fc06 Add function for creating derived array types. 2013-04-12 23:28:49 -04:00
Rene Gollent
b607f92d4e Improve tracing. 2013-04-12 23:28:48 -04:00
Rene Gollent
2298b5fc23 Resolve TODO.
- Added GetSystemInfo() to DebuggerInterface. Use that from
  DebugReportGenerator instead of calling get_system_info()/utsname()
  directly since otherwise we'd get the information for the wrong system
  in the eventual case when we have remote debugging support.
2013-04-12 23:28:48 -04:00
Rene Gollent
5a1b505fa1 Add model class for representing system information. 2013-04-12 23:28:47 -04:00
Siarzhuk Zharski
07d1d01afc Fix resize freeze on full-width chars in Terminal history
In the Terminal data model every full width character occupies two cells
in the data buffers. The second cell of such characters is not drawn and
used mainly to differentiate between full width and half width
characters.
Proposed fix zeroes the attributes of the second cell in the
HistoryBuffer::GetTerminalLineAt() that prevents the potential endless
loops in the BasicTerminalBuffer::_ResizeRedraw(). Those loops were
result of the random attributes in full width character's second cells.
2013-04-11 22:23:22 +02:00
John Scipione
b76cec7d9c Pass a pointer to the TBarView object into the ExpandoMenuBar constructor
I fear that perhaps the fBarView variable may be accessed before it has a
chance to be set in AttachedToWindow(). By setting it in the constructor there
is no chance of this. Might fix #9656
2013-04-10 15:23:17 -04:00
John Scipione
2b8d413116 Remove dead code 2013-04-07 14:54:06 -04:00
John Scipione
86c4eae3ce Also nullify other saved items on delete 2013-04-07 14:46:24 -04:00
John Scipione
1dccb7aaaf Don't call DrawExpanderArrow() directly, set a variable and Invalidate() 2013-04-07 14:46:23 -04:00
Siarzhuk Zharski
3d1492487d Fix support of East Asian Full Width characters
* Re-enable full-width characters detection and display;
* Fix cursor drawing on full-width characters;
* Fix debug dump for multi-byte characters;
* Fix file permissions for debug capture log.

Fixes #6717. Also may improve behaviour related to #6227.
2013-04-07 20:18:21 +02:00
Siarzhuk Zharski
4e17bdd83f Fix CID991252: Possible NULL dereference on scheme name
The color scheme name pointer is dereferenced but was not checked for
NULL value.
2013-04-07 19:47:51 +02:00
Siarzhuk Zharski
b249a7ce43 Fix CID991683: Uninitalized scalar field
fOldTitleUSerDefined was (surprice-surprice!) not defined.
2013-04-07 19:47:39 +02:00
Siarzhuk Zharski
34a1a44dad Fix CID609944: Uninitialized scalar field
Default constructor for UTF8Char has not initialize it's data.
2013-04-07 19:46:57 +02:00
Siarzhuk Zharski
4755a0794e Fix CID992335,CID992334: Check FindRef/String returns
Satisfy Coverity by checking return values of FindRef and FindString
calls for fSavedMessage.

Resolves CID992335 and CID992334.
2013-04-07 19:46:00 +02:00
John Scipione
9f2cce2faa Eliminate repeating CountItems() loop premature micro-optimization
Loop backwards if possible, if not, set a variable and use that instead.
There were a couple of instances where the loop style got changed from
    for (int32 i = CountItems(); --i >= 0;)
to
    for (int32 i = CountItems() - 1; i >= 0; i--) {
but should be functionally equivalent.
2013-04-07 13:01:29 -04:00
John Scipione
e6b6af80bd Fix a crash bug I introduced to Deskbar last commit
Need to set fLastClickedItem to NULL so it doesn't point to a deleted item.
Sorry about that.
2013-04-07 03:29:11 -04:00
John Scipione
5b0fd10d23 Animate the expander arrow
On MouseDown draw a diagonal arrow, on MouseUp complete the animation and
expand. If you hold down the button it will stay diagonal until you MouseUp
and either return to normal or animate and expand if over the arrow.

Reformatted ExpandoMenuBar.h and TeamMenuItem.h
Renamed fLastClickItem to fLastClickedItem
Added a DrawExpanderArrow() method
Renamed private InitData() method to _InitData() and moved it to the bottom
2013-04-07 03:02:05 -04:00
John Scipione
c6b72ad6e4 Tiny style fix, thanks Axel 2013-04-07 03:02:00 -04:00
John Scipione
542de916c4 Add and use an _Init() method for BarTeamInfo 2013-04-06 22:45:33 -04:00
John Scipione
de49a051ea Update expander arrows to point right or down (if expanded)
... like BeOS R5. I looked in the commmit logs for this one and there wasn't really any
explination for why this got changed, so, I'm changing it back to the way it was in R5 which
is right arrow for unexpanded, down arrow for expanded. Please yell at me if this change
was intentional.
2013-04-06 22:12:47 -04:00
John Scipione
9bc3b671fb Fix a bug involving the Vulcan Death Grip closing the wrong app
If you have expander turned on with expanded apps and you quickly remove teams with the VDG
you can remove a team not under your mouse pointer, instead you remote the team above. This
is because the window watcher thread hasn't updated yet so the TeamItemAtPoint() method
reads a window menu item instead of the team item. The solution is to lock the window
watcher thread and explicitly remove the window menu items in RemoveTeam().

This bug can be really bad if you accidentially VDG Tracker as your system gets hosed until
you restart Tracker or reboot.
2013-04-06 22:12:46 -04:00
Rene Gollent
e257ac49cb Add human-readable formatting for area protection/locking flags. 2013-04-06 20:38:04 -04:00
Rene Gollent
631624fb01 Dump semaphore information in reports.
Implements final part of #9510.
2013-04-05 09:43:22 -04:00
Rene Gollent
81ccf71fa2 Fix x86-64 build. 2013-04-05 09:42:56 -04:00
Rene Gollent
dbf6921a9f Extend DebuggerInterface for semaphore information retrieval. 2013-04-05 09:34:01 -04:00
Rene Gollent
dcbc00c3cf Add model classes for representing semaphore information. 2013-04-05 09:29:40 -04:00
Rene Gollent
adf25fc437 Dump area information in reports.
Implements part of #9510.
2013-04-05 09:12:51 -04:00
Rene Gollent
6d1e057cac Extend DebuggerInterface for area information retrieval. 2013-04-05 09:11:57 -04:00
Rene Gollent
a5e54e1bcf Add model classes for representing area information. 2013-04-05 09:11:56 -04:00
John Scipione
2cfeb3ca9c Update StyledEdit to use document background color. Style fixes.
See ticket #5293 Colors_picture2.png
2013-04-04 21:00:28 -04:00
Pawel Dziepak
ffbf0328d2 debug: update debug kit to correctly recognize commpage 2013-04-04 15:27:23 +02:00
Rene Gollent
88e692e89f Ignore calls whose purpose is to calculate the GOT address.
- Fixes several false positives where we'd show a return value for the
  current function.
2013-03-29 22:33:51 -04:00
Rene Gollent
2c6fab1de6 Handle return value CPU states.
- DwarfStackFrameDebugInfo::CreateReturnValue() now takes a cpu state
  parameter. This is attached to the associated Variable object.

- ResolveValueNodeJob() now checks if the value node child it's dealing
  with is that of a variable. If so it pulls that CpuState for the
  ValueLoader's purposes rather than the current state. This gets return
  values for multiple function calls in the same statement working.
2013-03-29 21:11:22 -04:00
Rene Gollent
47ffc32bc0 Minor refactoring.
- Factor out a _HasExitedFrame() function.
- Reorder how/where return values are added a bit.
2013-03-29 21:11:21 -04:00
Rene Gollent
c07e2b1fe4 Add optional cpu state to Variable.
- Used to preserve the CPU state for variables representing return
  values, since they may potentially be retrieved from registers,
  and these might be overwritten later in the same statement.
2013-03-29 21:11:20 -04:00
Siarzhuk Zharski
15aa771390 Keep color control enabled after color scheme change
Fixes #9532
2013-03-29 16:26:32 +01:00