1858 Commits

Author SHA1 Message Date
Humdinger
1e174254d6 Media replicant: fix menu label "Sounds preferences"
Change-Id: I561393f3d8663e650a27380eb45bcf4412af87a9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5076
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2022-03-08 07:08:22 +00:00
Augustin Cavalier
e88ab494a8 pkgman: Note in full-sync command summary that it may downgrade packages.
Fixes #10835.
2022-02-07 16:20:33 -05:00
X512
fce7f3a748 integrate AutoDeleter's into pointers
Change-Id: I6c3925a7aec4d0647c76c2a03aad7b08985d7166
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3490
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2022-02-02 19:29:52 +00:00
Jérôme Duval
101dc0ba83 strace: fix revents output for poll syscall
each poll_fd struct should be checked, valid when not -1 and revents not zero.

Change-Id: Ia624ad1369ad1a6066c9970a47cfac63fa773702
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4821
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2021-12-17 20:40:55 +00:00
Jérôme Duval
949005a59b strace: handle parallel syscalls on different threads
If a thread executes a system call and meanwhile a different thread calls another one, then
the ongoing call is marked as unfinished. When the call returns it will be marked as resumed.

* remove PreSyscall, now unused.

Change-Id: Iea45b866be2c40568d766c2ed3cc73e34b9d1293
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4765
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2021-12-06 17:22:50 +00:00
Jérôme Duval
39782e55fa strace: support trace for poll() and select()
in the case of poll(), the events should be printed before the actual syscall,
and the revents after, while taking in account the return value.
thus B_DEBUGGER_MESSAGE_PRE_SYSCALL needs to be enabled and handled.
the attribute "preSyscall" is added to identify such syscalls, and the parameters
are identified with the attribute "inOut".

Change-Id: I390643ea176c720738c5ec4fc75a3a4c7125a3cd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4763
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2021-12-06 03:07:41 +00:00
Jérôme Duval
c53f760dfe strace: add some constants ioctl from sys/ioctl.h
Change-Id: I100f715f899435c6a9bce775d95da6f755ba55c6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4762
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2021-12-06 03:07:41 +00:00
Augustin Cavalier
711e2dc05b Adjust all struct dirent creations (again), this time to use offsetof().
The dirent struct is not packed, so offsetof(dirent, d_name) != sizeof(dirent).
Thus in order not to waste the alignment bytes (which are significant,
on x86_64 at least, sizeof(dirent)==32, but offsetof(...)=26.)

This is also the most portable way to handle things, and should
work just fine in cross-platform code that has a non-zero-sized d_name.
2021-12-01 17:05:40 -05:00
Jérôme Duval
7c2c355f17 kernel: add frequency in cpu_info
use this in sysinfo.

Change-Id: I270ef1ab18c27c4804cb0cca2cb5088a17162636
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3214
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-11-22 07:20:25 +00:00
Augustin Cavalier
f35fc7ebda Remove some dynamic exception specifiers.
GCC 11 does not like them, and GCC 2 does not seem to care.
2021-11-17 21:08:49 -05:00
Coldfirex
2ca1376080 Mass updating of OpenBeOS text to Haiku
No functional code altered.

https://dev.haiku-os.org/ticket/17197

Change-Id: I75cc74f6be0ad968fd77c31fbe5b0f650a6fe9e0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4364
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-11-07 10:00:35 +00:00
Augustin Cavalier
fd276f19fe package command: -z now takes an argument to specify the compression method.
The upcoming change to use zstd by default will make the -z no-argument
variant obsolete, so instead we need to support passing "zstd" or "zlib"
to actually indicate the compression method we want to use.
2021-10-26 16:24:22 -04:00
Augustin Cavalier
fd7438acec package command: Remove duplicate code in recompress. 2021-10-26 16:24:22 -04:00
Augustin Cavalier
04a7f3ede0 package command: De-wrap help lines.
Now that the coding style limit is 100. Slight tweaks as well.
2021-10-26 16:24:22 -04:00
Murai Takashi
f4742397e0 bin/rc: fix wrong type of arguments to formatting function
Pointed out by LGTM

Change-Id: If0a6c3a5b951f360a4ff9e3d112d4d9799b12fb4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4626
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2021-10-20 18:03:03 +00:00
Franck LeCodeur
9a594d0a60 bus_managers/firewire: Fix warnings
Add parenthesis for macro processing, change variable type for signedness comparison warning

Change-Id: I67125ac1dfc97583ecb9e5706909a0a09cda7a2e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4575
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-10-20 18:00:36 +00:00
Augustin Cavalier
eb1d596ff6 Remove B_FILE_NOT_FOUND from public headers.
Now that it is not used anywhere in the source tree following
previous commits.

Change-Id: Id2fc417a0658d09148e99587c613a928f1fbe4c2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4611
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-10-19 15:58:54 +00:00
Augustin Cavalier
1a3be0addd Replace usages of B_FILE_NOT_FOUND in non-BeOS-API code.
B_FILE_NOT_FOUND was deprecated in BeOS R5 in favor of B_ENTRY_NOT_FOUND,
but it remained in Haiku and was never removed even conditionally, so
we have accumulated a number of usages of it.

This commit changes all the usages of it in new code, applications,
or anything else that BeOS applications will otherwise never see,
and so should be relatively safe.
2021-10-19 11:33:47 -04:00
Murai Takashi
41ed621ea6 bin/debug/strace: fix wrong type of arguments to formatting function
Pointed out by LGTM

Change-Id: If8ca0a8c9b6c3be4c888921a7a704cd351d5e115
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4605
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-10-19 07:58:52 +00:00
Jérôme Duval
52b4ed6028 Errors.h: add ENOTRECOVERABLE and EOWNERDEAD from POSIX
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html
Change-Id: I3c0a08d447c897b3caba8d365f8e5dbab7869f18
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4573
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2021-10-16 08:23:28 +00:00
Coldfirex
120e8f6ace Listusb: Fix Wformat-security
Change-Id: Ibd750392467ae097b8728346bd0e9ce33a461a06
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4481
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-09-20 13:38:53 +00:00
Coldfirex
5d9604a222 ifconfig: Fix Wformat-security
Change-Id: Ie4cf563f1ac333824932e1154e44d23e5ea046e3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4482
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-09-20 13:38:53 +00:00
Augustin Cavalier
86b6d54b46 listusb: Fix typo in usb_audio descriptor printing. 2021-09-06 16:50:27 -04:00
Coldfirex
925f912596 FTPD: Pull in various commits from upstream
Our version is from roughly 4-2007.

Brought in the following commits that appeared relevant to code improvements and fixes.:

f0b40b1c97 (diff-ccb7a49e05dd2061a0b3ac926212bc5aebe5afd09bbefc8658ba57d8b79827a1)
d56cc55917 (diff-ccb7a49e05dd2061a0b3ac926212bc5aebe5afd09bbefc8658ba57d8b79827a1)
763e8c9623 (diff-ccb7a49e05dd2061a0b3ac926212bc5aebe5afd09bbefc8658ba57d8b79827a1)
62f390ecd9 (diff-ccb7a49e05dd2061a0b3ac926212bc5aebe5afd09bbefc8658ba57d8b79827a1)
6e4fcca0f8 (diff-ccb7a49e05dd2061a0b3ac926212bc5aebe5afd09bbefc8658ba57d8b79827a1)
69097cd8da (diff-ccb7a49e05dd2061a0b3ac926212bc5aebe5afd09bbefc8658ba57d8b79827a1)
3c0c1e01c9 (diff-ccb7a49e05dd2061a0b3ac926212bc5aebe5afd09bbefc8658ba57d8b79827a1)

Change-Id: If44f58950513ebe1fecc2f482ea954fe49263677
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4321
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2021-08-10 12:49:49 +00:00
Coldfirex
64897ae792 FTPD: va_list 'ap' was opened but not closed by va_end()
as pointed out by cppcheck

Notified upstream FreeBSD of issue.  They realized this was dead code and ripped out.  Syncing those specific changes only.

https://github.com/freebsd/freebsd-src/pull/517
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257317
https://cgit.freebsd.org/src/commit/?id=674400eb20b65369a88b1cb778d729bc297832c9

Change-Id: I4951fa3ce42798895a8222d927067640267d0bbc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4214
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
2021-07-29 12:46:45 +00:00
Coldfirex
3f596320bf telnetd: va_list 'args' was opened but closed in wrong location
as pointed out via cppcheck. Fix from upstream.

Change-Id: Idfb59ca86bb4ed3767d8327c145ad348cb645e24
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4216
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2021-07-23 04:43:00 +00:00
David Sebek
3e19f197fa Extend the functionality of bin/fstrim
Improvements:
* Introduce new command-line parameters for the offset and length
  of the trimmed region
* Introduce a new command-line parameter that must be specified
  in order to trim a block/character device instead of a file system
* By default, warn users that trim can potentially destroy data
* Display the number of bytes trimmed even if the ioctl returns
  an error

Change-Id: I9eec535abe74f7ef09c927292a120016f4156684
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4154
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-07-14 10:55:41 +00:00
Murai Takashi
0071f2c477 cddb_lookup: Update default server
Fix part of #17023
* Update default server to "gnudb.gnudb.org:80".
* Add "/" to command footer to work with gnudb.

Change-Id: I363ca919d971e96ba27476a56ca06b4e8fa99171
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4112
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
2021-06-24 12:50:49 +00:00
Jérôme Duval
7903bfcf8b strace: add signal name tracing
inspired by hrev23436, fix #10944

Change-Id: Ieedace86a6541a4cd1346791146a96e99d09d614
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4093
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
2021-06-15 14:34:56 +00:00
Murai Takashi
1d1b0d4594 bin/network/telnetd: Fix multiple definitions
Fix multiple definitions of 'terminaltype' and 'line' when linking.
Pointed out by gcc11.

Change-Id: I85552e2d243bd5db5f80806d92e6fa87bc41eb44
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3903
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2021-05-12 12:50:45 +00:00
Alexander von Gluck IV
ad284e7acb ifconfig: expand 10Gbps media knowledge
* These are pretty much the 10G standards that have
  any potential for usage on a desktop system.

Change-Id: I2cb49f41ca61e82e091d042f877ee2f1acb9c4ec
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3900
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-05-05 12:52:12 +00:00
Murai Takashi
08f2b4d50a filepanel: Fix -Wformat-security and remove unused options.
Change-Id: Iedf3bb500de15a29188c30940b5fd64dcaf043f5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3319
Reviewed-by: Niels Sascha Reedijk <niels.reedijk@gmail.com>
2021-03-06 08:03:38 +00:00
Murai Takashi
68ff03664f mail_utils/mail: Fix -Wwrite-strings
Change-Id: I57f231cca2137daee8f1f2f3caa6cd9f282be0ed
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3626
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-01-12 16:27:24 +00:00
Murai Takashi
acada5ef55 spamdbm: Fix -Wmisleading-indentation
Change-Id: I0f7d5a10e2068f2359f93afff35f44db81b66a53
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3624
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2021-01-12 07:44:40 +00:00
Jérôme Duval
62826a0665 strace: continue_thread can fail when the origin team is gone
Change-Id: I2de8aaaf90ef987d3871dbbbef73c49240d99a89
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3615
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2021-01-09 18:10:39 +00:00
X512
cdccd323b5 use common AutoDeleter types
Change-Id: I115e14b76f3ff049c5f7d9471efd3619a0038fcf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3483
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
2020-12-13 19:14:13 +00:00
Murai Takashi
b66b01c283 bin/bfs_tools: Fix array index is out of bounds
If length == BPLUSTREE_MAX_KEY_LENGTH at line 237,
buffer[] index may be out of bounds at line 245.
Pointed out by cppcheck.

Change-Id: Ib86abeaa72526b327af85ca9a26b050834f5a2c9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3501
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-12-13 16:44:30 +00:00
X512
36aafa560b fix build after CObjectDeleter interface change
Change-Id: I76e217abcd13c22c4d68170e07333cdde4d7a891
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3461
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-12-10 11:39:49 +00:00
Murai Takashi
2c08d25325 bin/media_client: Fix memory leak
Fix leak of memory allocated to 'app'.
Pointed out by Clang Static Analyzer.

Change-Id: I59d39b76a18893bd284db1d75e40620bb1aee9e2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3480
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
2020-12-09 16:12:43 +00:00
Murai Takashi
6cd9975b85 bin/keymap: Fix memory leak
Fix leak of memory allocated to 'app'.
Pointed out by Clang Static Analyzer.

Change-Id: I2cbd005d42d4747937ee4b6e12ccf409f122ea24
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3478
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-12-08 12:27:40 +00:00
Murai Takashi
064bd70dcf bin/network/arp: Fix -Wformat-security
Change-Id: Ia9ceb05b555fad32bed66ad232cc1b08a1b4a881
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3369
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-11-17 07:25:05 +00:00
Murai Takashi
0e1b1021ea bin/multiuser: Fix -Wformat-secrity
Change-Id: Iee07090f57973d8fc687cd7d9974c7ceb4517571
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3368
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-11-17 07:20:36 +00:00
Jérôme Duval
b05d6f0af0 POSIX: asprintf and vasprintf are BSD/GNU extensions
fix #16259

Change-Id: Ia16bb6e1944b87b25d1a940bbdaaf6e236db1abf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3381
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-11-07 08:49:34 +00:00
Murai Takashi
aaca5974ec bin/top: Fix -Wformat-security
Change-Id: I40bec25162d03f5af3a12f7b6a51d88be4c6e7b8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3370
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-11-02 07:22:26 +00:00
Jérôme Duval
4a722a65f3 strace: Added a few more types to termios ioctls.
Change-Id: I863a0a9bc6ad7527a56465246acac073f8878809
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3365
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-10-29 14:31:30 +00:00
Murai Takashi
17904e6253 bin/df: Fix -Wformat-security
Change-Id: Ib8e3000f9b16ef055269728fde3adaf1005a4fba
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3353
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-10-28 16:26:35 +00:00
Murai Takashi
2613144749 bin/urlwrapper: Fix -Wmisleading-indentation
Fix misleadingly indented printf() at line 142.

Change-Id: I498d171db6a09425901a13d52a8b2eca1413a068
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3342
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-10-23 07:09:20 +00:00
Murai Takashi
1363e29b52 bin/safemode: Fix -Wimplicit-function-declaration
Fix implicit declaration of strcmp() at line 25.

Change-Id: I1653157b417b8b7da3936405d038150309999226
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3336
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-10-23 07:08:25 +00:00
Murai Takashi
097d6b9ce3 bin/locale/collectcatkeys: Fix -Wformat-security
Change-Id: I7e09dd3d8eac8eeb6c4b92e9d9ebf61d5a7b9f5a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3338
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-10-22 05:59:30 +00:00
Murai Takashi
a2efc1d6e0 netstat: Fix -Wformat=
Change-Id: I70bfb12f9d56e7e4c8dbdd4bd48ca0282057a713
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3312
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-10-13 15:19:05 +00:00