BuildReportList checks that the array does not already holds the reports
before adding them. If one of the uninitialized elements happened to be
the address of one of the reports, it would not get added again,
possibly leading to items in the array being in the wrong order. Just be
safe and clear the array.
Fixes #10221, patch there not used as it cluttered the code more than
needed.
* This was never implemented and no one noticed until now.
* A default value for a pointer doesn't make that much sense anyway, so
using the FindPointer method is fine.
* synth_file_reader: TList to BObjectList.
* delete two old prototypes of MidiPlayer and the README noting that
they should be removed
* delete reference to PatchBay which was moved to src/apps in 2013.
Fixes #7027.
BeOS did allow other threads than the owner to unlock a BLocker (the be
book says so). We did not, and silently ignored the unlock attempt in
this case, probably resulting in a deadlock of applications using the
feature.
Call debugger instead so:
* The problem is made visible for such apps
* The debugger call is continuable so the app can be run, still
Will help making a decision on what to do here (follow BeOS or change
behavior) and make a final decision for #6400.
int64_t is signed. Although it does not make a difference by itself, because
INT64_MAX is still a valid number for uint64_t (UL), the later INT64_MIN
declaration depends on INT64_MAX, and therefore got implicitly casted to
unsigned type.
This fixes the following program on a x86_64 system:
#include <stdint.h>
int main() {
int64_t test = 5;
if (test < INT64_MIN)
return 1;
return 0;
}
This is a regression since commit 1d13a609 ("stdint.h: define [U]INT64[MAX|MIN]
with [U]L on x86_64").
Signed-off-by: Jerome Duval <jerome.duval@gmail.com>
The menu item to set the "Window title..." makes more sense in the
"Settings" menu. There you find other settings that only apply to
the running session, like window size or text encoding.
The "Edit" menu OTOH has only commands to deal with the contents
in the Terminal, like copy, paste, find etc.
Could lead to wrongly setting the TYPE_MINUTE flag for an invalid (>59)
number of minutes. Harmless, as that flag is never used.
For completeness, also set the flag for seconds (also never used).
Fixes #11552.
If the text in the button is longer than what the minimal size of
BButton allows, the button exapnd. But we want the two buttons to have
the same width and stay aligned.
Fixes part of #11471.
Note: I don't understand why I need to set the explicit max size of the
button to make it bigger (I would have expected setting the minimal size
to do that), but it works.
get_vnode could be called with a NULL privateNode in the kernel, but not
in userlandfs. This would crash in cdda mount code (and from a grep
search, also with several other filesystems).
Now cdda can be mounted with userlandfs, and CDs read that way, but for
some reason there is no CDDB renaming of the tracks in that case.
