0059775c1d
This saves 40 bytes from the size of Node (on 64-bit architectures.) UnpackingDirectory is still at 200 bytes, while UnpackingLeafNode is now 96 instead of 136. This saves ~5MB of memory on my system (UnpackingLeafNodes go from 16.2MB to 11.2MB.) The general strategy is for Directories to use their own locks, while all other nodes read-lock their parent directory during use. There are a few edge cases around node creation and removal in the case of non-directory nodes; see inline comments in Volume's _RemoveNodeAndVNode as well as packagefs_put_vnode. Since it's now possible for a node's parent to change or be deleted when we don't have the lock (but only a reference), we need a lock protecting just that field to hold while we acquire a reference to the parent. (Right now, this is just one static rw_lock for all Nodes; this could be changed in the future if necessary, but it seems performant enough for the moment.) Tested with basic system functionality, installing/uninstalling packages, uninstalling packages with files still in use, HaikuPorter builds, and more. All still seems to work as expected. Change-Id: I054187316c66b77ea1951c6d1ea8e5b75715c082 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7930 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.