09c7b1526f
In 02cb8503d252cdb896ce01b0d1e436defdb45932, I added the m_next and m_nextpkt structures to mbuf, as per FreeBSD's mbufq system that FreeBSD 11.1's net80211 code uses. What I didn't realize (and korli and PulkoMandy who reviewed my code didn't notice either) is that the data fields in mbuf are sometimes dealt with through these LEN macros, which were now incorrect after such changes. This caused an out-of-bounds memory write for data above a certain size that was attempting to be written into an mbuf that under the old sizing would have been fine, but under this new sizing was invalid, and this manifested itself as a KDL under the guarded_heap (#14207). It possibly also manifested itself as a stack-smash with the new net80211 code (uncommitted on a local machine, and the reason I tried using the guarded heap in the first place.) Now we use FreeBSD 11's macros, which use offsetof instead of raw integer math. This means that we can't specify the struct size in mbuf as these structs are computed from mbuf's definition, and thus have to rely on the allocator giving mbuf the correct size (as FreeBSD does also.)
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our OpenGrok servers:
- http://xref.plausible.coop/ (provided by Landon Fuller)
- http://code.metager.de/source/xref/haiku (provided by MetaGer)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.