3c416c7aa7
This ASSERT causes a crash in the debug build of libtracker.so. The crash occurs when two conditions are met: 1. There are files in the directory with icons specific to them. This is the case with image files, whose icons preview what the contents of the image are. 2. Tracker has not displayed those icons yet. This happens if the user has not scrolled down far enough to see the icons. One way to meet these conditions is to configure the build system to compile a debug build of libtracker.so. Then compile icon-o-matic. Then run icon-o-matic with the debug build of libtracker.so LD_PRELOAD'ed. With that, press File->Open and navigate to /system/documentation/BeBook/images/admonitions. While in the images folder, do not scroll up or down to view the icons of the images in the folder. They should remain unrendered. It should crash as soon as Tracker enters the admonitions folder. The crash occurs because NodeIconCache::Deleting is called without a corresponding call to NodeIconCache::AddItem. Tracker calls NodeIconCache::AddItem whenever it renders an icon to cache the result. Tracker, however, is lazy, and only renders the icon when it comes into view. When navigating out of the directory, Tracker has to call Deleting for every file in the directory since it doesn't keep track of which icons it rendered and which icons it didn't. Thus, AddItem has been called for some of the files, but Deleting has been called for all of them, causing the assert to fail and the program to crash. This commit fixes the problem by not requiring a call to AddItem for each call to Deleting. Change-Id: I1038ce70ca345c44812becee7f3752567e5b562a Reviewed-on: https://review.haiku-os.org/c/haiku/+/6474 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.