c1c239fefb
This is needed by CreateSubRequest, which creates a sub-request using some subset of the passed IO vectors. In the case that the last vector will not be fully used, we need to clamp its size in the sub-request to the remaining length. do_iterative_fd_io, used by vfs_read_pages (which is in turn used by the file cache) used this to split up requests into their constituent block-run requests. So, previously, the invalid IO requests created by this could, under one possible interpretation, overwrite valid file data and cause disk corruption. It is slightly unfortunate that generic_size_t has no unsigned equivalent, so we are left with 0 as the magic number here, instead of -1. However, the passed "length" remains unchanged, so any callers that pass the wrong value for lastVecSize will be trapped by the assert added in the previous commit Fixes #15912 (the assert added in the previous commit), and potentially disk corruption caused by this.
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.