f9f6083f41
The logic in add_timer was scheduling the timer using "scheduleTime", the originally passed value, not "event->schedule_time", which is adjusted inside add_timer to be relative to the system_time. This meant that if the event was the first added to the list, we would set the hardware clock for a very long time in the future rather than the correct duration. Since until recently cancel_timer reset the hardware clock every run even if the cancelled timer wasn't at the head of the list, this problem was covered up by that one, as usually the scheduler would cancel a timer relatively frequently, and thus the hardware timer would usually get set to the correct value relatively frequently. But after c5a499a74b7a3516451337373e455bb2aba00ace, this was not the case anymore as we skip updating the hardware timer if we cancelled any timer other than the one at the head of the list, exposing this bug. The fix is simple: don't bother storing a local "scheduleTime" variable separate from the event->schedule_time. This makes things less confusing anyway. Fixes #18967.
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.