c2d37953f3
The limits were wrong in several places. Checked the sandy bridge, ivy brige and haswell docs, they all say mostly the same. - The value of p2 is either 7, 14, 5 or 10 depending on 1 bit in the config register and on the display type. We can guess which values are right according to the global P limit (5-80 when using 5/10, 28-something when using 14/7). The values are different because CRT need a precise, but rather low pixel clock, while modern display interface can accomodate being faster than required by a few MHz, but need a much higher speed (the bits are transferred serially, so they need to be at least 8 times faster than a DAC). - The limits for N were obviously wrong, as the register is written with N-2, so values less than 2 make no sense. Use 3-8 as specified in the datasheet. - The reference frequency (set by the driver) was wrong, too. It is 120MHz, not 96. It is 100MHz in some cases (FDI, etc), we should see when this happens and switch to the right reference for PLL computations. - There was an attempt to minimize the value of N (a powersaving effort, I guess?), but it would basically force the loop to stop at the first value of N tested, resulting in way off timings in some cases. - To ease testing and stop sending patches and syslogs back and forth with vidrep, extract the "test mode" from pll.cpp into a proper test executable, making it a little easier to experiment with the code and fix the problems. This should fix #13669 and possibly other cases of "out of range", black screen, bad timings, etc. Change-Id: Ic4c1c159701f352b7c1ef15a647f023c82ac26c Reviewed-on: https://review.haiku-os.org/360 Reviewed-by: Axel Dörfler <axeld@pinc-software.de> Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our OpenGrok servers:
- http://xref.plausible.coop/ (provided by Landon Fuller)
- http://code.metager.de/source/xref/haiku (provided by MetaGer)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.