16fca25e27
The "versions" table is populated from two sources: the elf "needed_version" and "version_definitions" tables. Both populate specific index in the version table. Each index has an hash, and one or two strings. The algorithm to find data in this table is to compare by hash, and then do an strcmp on the strings when the hash matches. However, nothing guarantees that all the indices in the version array will be used. Indeed, libavutil does not use the first two. These were left uninitialized. It could happen that one of these would accidentally have its hash equal to one of the actual hashes we need to lookup, and invalid string pointers. This would of course lead to a crash. This was reproductible easily with WebKit when loading the fmpeg add-on. I guess that hit just the right allocation/deallocation pattern to make the runtime_loader reuse memory from a block where it had previously stored the same hash. Anyway, just clear the whole version table after allocating, so that unused entries have an hash of 0 and NULL string pointers, this way they can't accidentally trigger a hash collision and crash everything.
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- http://xref.plausible.coop/ (OpenGrok, provided by Landon Fuller)
- http://cgit.haiku-os.org/ (cgit, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.