fbc30e9145
6c67c7d63 was attempting to fix a leak caught by a static analysis tool, but it actually just introduced a double-free bug. Running `UnitTester BString` will result in a crash. The original code was correct because, in the event that realloc() fails in BString::_Resize(), the value of fPrivateData is still retained. It will be freed by the destructor of BString only if fPrivateData is not shared by another BString instance, since BStrings are copy-on-write. Note that while the change in 6c67c7d63 caused tests to fail, that doesn't mean those tests are ideal. They only trigger BString::_Resize() to fail because they depend on implementation details of hoard2 which limits allocations via malloc() to 1GB. Most malloc() implementations will allow allocations of arbitrary sizes using anonymous mappings (mmap on Linux, or create_area() in Haiku). This is a much bigger change, so for now I'm just adding some comments so that we can revisit these tests if we make a change to the allocator. Change-Id: I208c1c7a76b6b4409d237b911c62bb3198e49dab Reviewed-on: https://review.haiku-os.org/c/haiku/+/2060 Reviewed-by: Stephan Aßmus <superstippi@gmx.de>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- http://xref.plausible.coop/ (OpenGrok, provided by Landon Fuller)
- http://cgit.haiku-os.org/ (cgit, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.