60f8e54f2b
The BFS on-disk data is not aligned. Reading it to memory and trying to access fields directly does not work on sparc. memcpy the data to an aligned variable before handling it with its native size. gcc knows how to access unaligned data, but we need to tell it when to do so. This is done with the "packed" attribute, but it works only on structs. So we have to wrap the values in a struct. Thanks to C++ features, we can make the struct relatively transparent by having an assigment operator (for writes) and a cast operator (for read access), so there is no need to access the value inside the struct with ".value" everywhere. The rest of the code is then largely unchanged (except for use in printf statements and other vararg functions, where the implicit casting can't work). gcc takes care of performing the access in the correct way on platforms that need it (old ARM, sparc) and can still optimize things on other architectures where specific code is not needed for unaligned access. Fixes #9255 Change-Id: I3bf62590dee059ad32b1845bdc4eace165b73203 Reviewed-on: https://review.haiku-os.org/c/haiku/+/2363 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.