0822ec27a9
PathTransformer keeps a reference to the VertexSource used (which can be either another PathTransformer, or the base path for a shape). When a shape is cloned, this should be retargetted to the new object in the clone. However, references are not settable, and so, what would happen instead is the original (non-cloned) vertex source was reinitialized (through the default implementation of the assignment operator) using data from the clone, and the clone would still point to it. Then, if the original object is deleted, the clone would point to freed memory. To avoid this problem, replace the reference with a pointer (which can be set to point elsewhere, as the code intended to do). To make sure this does not happen again, make the VertexSource copy constructor and assignment operator private, and deleted when the compiler supports that. Fixes #18577 Change-Id: I8870d9471c5064e922a84eff8447cbda783b13e6 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7052 Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk> Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: Zardshard <0azrune6@zard.anonaddy.com>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.