0b3890fea1
Fix _DuplicateKeys() conflict check for Caps Lock to ignore right side. - Create kUnset constant set to 0 so it's clear what's going on. - Create kDisabled constant set to -1 for that case. - Declare loop variables one time out of loop scope, uint => int for -1. Fix _MarkMenuItem() warnings icon check. We should get a yellow warning icon if your left and right modifiers don't match (except on Caps Lock). Create an _UpdateStatus() method that calls the other methods we need. Reverse the placement of the Revert and Cancel buttons. Cancel goes just to the left of the OK button and Revert goes all the way left. Restore _HideShowStatusIcons(), this is used to push the menu fields over when there is no conflict. _ToggleStatusIcon() convenience method. The key role is called "Caps Lock" not just Caps. Method and variable names are fine, but the " Lock" part is important in the label. Also use "Caps Lock key" instead of just "Caps Lock" for the menu field value. We use " key" at the end for the other cases to differentiate them from the role label. Minor nitpicks: - Change comment variable name to label. I understand that it says B_TRANSLATE_COMMENT, but it's a label, the comment is for i18n. - Fix same method declaration style, and in header. - Add 2 new lines after pragma instead of 1 Change-Id: I194e69486310a249d0ef2d5d5977ae69954e9a27 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7179 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.