f99596f4e3
This fixes crashes that happen when scrolling list views in Icon-O-Matic triggered by the BListView auto-scroll feature reintroduced in hrev57439. Take out the auto-scrolling code from Icon-O-Matic, call BListView's MouseMoved() instead since BListView's can scroll now. The BListView auto- scroll feature has been updated to work with draggable multi-select. ScrollTo(index) method has been moved from Icon-O-matic to BListView and is used to scroll to an index instead of a selection since the selection doesn't change while you are dragging. Override BListItem's DrawItem() method to prevent it from drawing. I've hijacked DrawItem()'s complete param to mean even or odd instead. Everybody draws the same background PathListView.cpp and StyleListView.cpp now push the frame over and draw text using SimpleListView parent class DrawItem() instead of repeating the drawing code. InitiateDrag got moved from the abstract DragSortableListView class to the SimpleListView implementation class. The following color constants have been added: rgb_color kDropIndicatorColor = make_color(255, 65, 54, 255); rgb_color kDragFrameColor = make_color(17, 17, 17, 255); First one is the red drop target indicator line. It has been changed to clrs.cc red which is the same as B_FAILURE_COLOR, but I didn't want to use that InterfaceDef constant as it doesn't indicate failure in this case, it's just a slightly different red. Second one is the drag selection outline, it has been changed from pure black to clrs.cc black which is a shade lighter than pure black. Fixes #18707 Change-Id: Ib0b375d7d5641d458a6ce004a6dfeac551636698 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7215 Reviewed-by: waddlesplash <waddlesplash@gmail.com> Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk> Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.