3ecbb34240
The IORequest internally likes to deal with transferEndOffset not transferredBytes because of sub-requests potentially being prepared all at once (in some paths in the I/O scheduler), thus fTransferSize can get incremented in Advance() before we have actually executed that transfer. But external consumers much prefer just knowing transferredBytes not transferEndOffset. And many of them actually named their variables that (or "bytesTransferred") and just passed the transferEndOffset through to variables with that name! That's obviously wrong, and it's surprising it wasn't discovered before now. The problem was uncovered by repeated KDLs in PrecacheIO. That method used the "bytesTransferred" value as a count of pages transferred, which would then run past the end of the array if the transfer start offset was not 0 (which the majority of the time it would be, since this method gets called on the first mmap() of a file, probably before any pages are read in.) Most other consumers of this API did not check the value, it seems, or otherwise had some mitigating factor that prevented it from causing more problems. An exception is the page code, which may have spuriously considered writes as successful when they really weren't. May fix some of the "invalid concurrent access to page" KDLs.
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.