bsnes_libretro: various fixes (#2282)

* Updated versioning, replaced SUPPLEMENTS with REQUIRES
* Replaced lib: by addon: for consistency.
* Added SOURCE_FILENAME.

games-emulation/bsnes_libretro/bsnes_libretro-0.94_20171227.recipe

@@ -7,10 +7,11 @@ attempting to provide a reasonable balance between the previous two."
 HOMEPAGE="https://byuu.org/emulation/higan/"
 COPYRIGHT="2014-2018 byuu, the libretro team"
 LICENSE="GNU GPL v3"
-REVISION="1"
+REVISION="2"
 srcGitRev="4e572a3cfa10e56bedb6737b0494e8165f6490d5"
 SOURCE_URI="https://github.com/libretro/bsnes-libretro/archive/$srcGitRev.tar.gz"
 CHECKSUM_SHA256="77255571b654ef1b7559608818393dc8377c657dc30aa7d3ec45e40662c99a31"
+SOURCE_FILENAME="bsnes-libretro-${portVersion/_/-}-$srcGitRev.tar.gz"
 SOURCE_DIR="bsnes-libretro-$srcGitRev"
 PATCHES="bsnes_libretro-$portVersion.patchset"
 ADDITIONAL_FILES="
@@ -24,14 +25,12 @@ SECONDARY_ARCHITECTURES="x86"
 
 PROVIDES="
 	bsnes_libretro$secondaryArchSuffix = $portVersion
-	lib:bsnes_accuracy_libretro$secondaryArchSuffix = $portVersion
-	lib:bsnes_balanced_libretro$secondaryArchSuffix = $portVersion
-	lib:bsnes_performance_libretro$secondaryArchSuffix = $portVersion
+	addon:bsnes_accuracy_libretro$secondaryArchSuffix = $portVersion
+	addon:bsnes_balanced_libretro$secondaryArchSuffix = $portVersion
+	addon:bsnes_performance_libretro$secondaryArchSuffix = $portVersion
 	"
 REQUIRES="
 	haiku$secondaryArchSuffix
-	"
-SUPPLEMENTS="
 	retroarch$secondaryArchSuffix
 	"
 
@@ -46,7 +45,7 @@ BUILD_PREREQUIRES="
 BUILD()
 {
 	for bsnesProfile in "accuracy" "balanced" "performance"; do
-		sed -e "s/@DISPLAY_VERSION@/v${portVersion%.git*}/" \
+		sed -e "s/@DISPLAY_VERSION@/v${portVersion/_/-}/" \
 			$portDir/additional-files/bsnes_"$bsnesProfile"_libretro.info.in \
 			> bsnes_"$bsnesProfile"_libretro.info
 		make $jobArgs profile="$bsnesProfile"
@@ -55,9 +54,9 @@ BUILD()
 
 INSTALL()
 {
-	install -d "$libDir"/libretro
+	install -m 0755 -d "$addOnsDir"/libretro
 	for bsnesProfile in "accuracy" "balanced" "performance"; do
-		install -t "$libDir"/libretro \
+		install -m 0644 -t "$addOnsDir"/libretro \
 			out/bsnes_"$bsnesProfile"_libretro.so \
 			bsnes_"$bsnesProfile"_libretro.info
 	done