* A clear UXN bit only implies B_EXECUTE_AREA if the page was also
user-readable.
Change-Id: I01203b6539cc60550a5825c663af5d8cfe57f751
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8423
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
* Save a TLB flush on the case where we only clear the accessed flag.
Change-Id: Icd9210d616a2eca13a9be9497f2a787ab0eaf266
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8422
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
* Make the recursion logic in much more explicit
* Resolves a rare assertion failure in Protect()
Change-Id: I9d93293836251e158ea226792852a63f6d91f3ab
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8366
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
All Pentium II and IIIs as well as some Pentium 4 models have an errata
saying that PAT is broken for the upper four entries at least in some
circumstances. As the upper entries are used for write-combining in our
PAT setup, avoid using PAT on such CPU models.
Change-Id: Iaf85eda06b656dc42f94257fc24802fc5d4bab14
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8419
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Iterating over every single page in a 64-bit address space is far
too expensive. Instead, use DebugGetReverseMappingInfo(), which
iterates over the page translation map's page tables.
(The only thing that implements this at present, however, is
X86VMTranslationMapPAE, so it won't be too useful on 64-bit
just yet. But at least we won't hang for very long periods
of time on 64-bit at least.)
* Fix an instance of storing block number in a signed 32-bit variable,
which could overflow on volumes > 1 TiB.
* See discussion in #11119.
Change-Id: I138b56613775c364b259e3a0e68ba8bfe9a7f904
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8362
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
* Unfortunately, functionality of Haiku r1beta5 under
gcp is blocked by #18962 (virtio_scsi not getting irqs
with our now guarded heap)
Change-Id: Ibf70419762e9a222bcb86b7418282cc409e17986
* Trim down comment about fno-delete-null-pointer-checks.
* Remove -fno-builtin-fork -fno-builtin-vfork, they don't seem
to be needed with GCC 13.
* Remove legacy-GCC settings from kernel flags, as we don't use
legacy-GCC there anymore. Also drop fno-builtin as ffreestanding
implies this.
From the spec:
"After writing 0 to device_status, the driver MUST wait for a read
of device_status to return 0 before reinitializing the device."
Change-Id: Ib708d6ec843877b40cdb64c15beacec3dcc4c009
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8358
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
This breaks kernel C++ ABI.
This mostly just changes the definition (not the size) of string types,
but in at least one case (daddr_t) it does change the size (from 32-
to 64-bit.)
_BEOS_R5_COMPATIBLE_ was defined in ArchitectureRules while
__HAIKU_BEOS_COMPATIBLE is defined in HaikuConfig.h (which is
in the include path for sys/types, SupportDefs, and other
base headers.)
* If this was set too small by EFI, some MMIO addresses could end up out
of range and trigger Address Size Faults.
Change-Id: I29280e1f536cfd64c4711b3b702418cd43699278
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8357
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: Fredrik Holmqvist <fredrik.holmqvist@gmail.com>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
* When booting in EL2, TTBR0_EL1 may not be initialized if VHE
extensions are not enabled. To handle this case, we need to use
TTBR0_EL2 until we transition to EL1, at which time the contents
of TTBR0_EL2 get copied to TTBR0_EL1.
Change-Id: Iadaa1f30d016397c5fd0426c891b3443dd8805e3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8350
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
In "by attribute" mode, the attribute popup and AND/OR popup menus
are needlessly wide, while the text input field could be wider.
This change increases the weight of the text column, making those
popup menus less wide.
Fixes #19116
Change-Id: I347583cdb7d8e399f83f56cc2d167084e1483ba8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8356
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
* _DisplayPartitionError() adds quotes to the partition name variable (%s).
So when calling it, the passed string musn't have the variable in quotes
already (\"%s\") or we'll end up with duplicate quotes.
* Anywhere else we see a partition name variable, it should have quotes.
This change fixes two places that didn't before.
Change-Id: I37e806c9dceea3c2a2b52a7cb139d7c32e976d5c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8353
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
The don't-wait and do-wait logic was very similar except for the
actual acquisition of the lock in the middle, so now they're combined.
This fixes another (minor) regression from 9e89f7c068c3b3b4c9d74bb82679c27a2c12b10a
in that if a page's cache changed before we acquired its lock and
don't-wait was set, we would wind up waiting anyway.
This fixes a regression from 9e89f7c068c3b3b4c9d74bb82679c27a2c12b10a.
Even if SwitchFromReadLock fails, the original read lock has been released,
and so we need to re-acquire the lock before continuing.
Should fix a KDL reported by X512.
The clock hands do not always point exactly at the hour marks, which is
easy to see using Magnify (or a flat screen with sufficiently large
pixels): when a hand tries to points at 3 or 12 hours exactly, the
resulting line is not horizontal or vertical.
This is because the hands lines hinge on an array of coordinates, which
are calculated at run time using pi, and the calculation used to
approximate pi value as 3.1415. This has been the case since respective
BeOS developer sample code from 1999 was imported into Haiku repository
in the initial commit in 2002. Interestingly, BeOS R5.0.3 clock demo
does not have this bug.
Use M_PI for the pi value, point the hands precisely and fix my bug
report #19083.
Change-Id: Ie71889daed2efccd1596586f95b629f3b8e14c03
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8352
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Previously wonderbrush was closed source and only available for 32bit
x86, but that is not the case anymore.
Fixes #19093
Change-Id: I05a34f7aaf82ea7cc2f65b7cbd39eeaf222d6143
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8351
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
* It turns out that `end` is inclusive.
Change-Id: I1d29e975afcfc1c6812fdf9ac8bfbbb3ac1e46bc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8348
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Fredrik Holmqvist <fredrik.holmqvist@gmail.com>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
* Put disabled code behind #if 0 instead of comments, as per style guide.
* Clean up comments.
* Errors should be ERROR not INFO (but both are printed anyway
at the moment.)
No functional change intended.
* This could result in us inadvertently unmapping more pages than
intended.
Change-Id: I2513028cd18436aadd29749628944a853e65e1c4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8346
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: Fredrik Holmqvist <fredrik.holmqvist@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
We automatically enable _DEFAULT_SOURCE if _GNU_SOURCE is defined.
Rather than having even more optional methods undefined unless
_GNU_SOURCE manually is, just change all remaining guarts to
use _DEFAULT_SOURCE instead.
Fixes #19095.
Change-Id: I5c7baf40b7fb37913e24279589fc1ae706448a45
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8330
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
The names chosen (e.g. "B_UNCACHED_MEMORY") follow the existing naming
conventions for memory-related constants, of putting the type at the end
of the name: B_KERNEL_BLOCK_ADDRESS, B_FULL_LOCK, B_READ_AREA, etc.
Resolves a very old TODO. No functional change intended.
Change-Id: I31491f6b3abc1e95f915aa302b9f2fb2af14774c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8316
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
