We need O_CLOEXEC here, not FD_CLOEXEC (which is equal to 0x1, which
in openflags is O_WRONLY and thus leads to the conflicts caught by
the previous commit.)
Fixes haikuports/haikuports#7524.
Otherwise we will have open modes that could have both and lead to
confusion in code that presumes only one will be set.
This catches the cause of some ported software (e.g. Wayland layer)
misbehaving with ramfs mounted in /var/shared_memory: the ramfs does not
properly handle both flags set, and due to another bug, they are for
shm_open'ed files.
This will allow proper operation of POSIX SHM API (shm_open etc.).
Now memory files are stored fully in memory and do not affect disk
storage (except swap if enabled).
Change-Id: Iae3ce1afa968df72e82198e598a273cbf7cb0269
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5802
Reviewed-by: Fredrik Holmqvist <fredrik.holmqvist@gmail.com>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
(cherry picked from commit bf2786efae)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5851
This saves 16 bytes in the class vs. the old size, but more importantly
allows us to avoid allocating VMCaches and wasting an entire page for
any attribute larger than 32 bytes; instead, attributes can be up to
1024 bytes before we allocate a full page for them.
Unfortunately small files cannot take advantage of this optimization
right now as the cache is always used for them. I added a TODO about
this.
(cherry picked from commit 396e3dfb9c)
Change-Id: I6c939565dd577cb86aeb7b518a219da01cb313a1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5849
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
As, of course, we are deleting it. This problem was obscured by the
one fixed by the previous commit.
(cherry picked from commit 4e742d81ab)
Change-Id: I071b6356d85fb4e834125fa4a453b8ebf206510a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5848
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
* RemoveReference() could delete us immediately, thus we must do
all important work before invoking it.
* Add assertions about fRefCount and remove a spurious add.
* Do not use Link but PublishVNode on the root, as we manually manage
when this object is published/deleted.
Fixes #18032.
(cherry picked from commit 605ecac1ee)
Change-Id: I696e652bc4094baacb5336b1180d8b90f3f0f864
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5847
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
* We do not want to set fNode in the constructor but let the invocation
of Link() take care of doing so instead.
* Link/Unlink manipulate linked-lists. Thus it is dangerous to use them
in tandem on the same Node object. Add a check for this.
* Minor cleanup.
(cherry picked from commit 6a8bb0562e)
Change-Id: Iec3c8596d4b8fa24be94247a1f29b9cbdf9909fe
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5846
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
remove the yarrow module. the hardware modules can push entropy with queue_randomness().
virtio_rng will now push entropy every 300 seconds.
helps with #14937
Change-Id: If76c5deabf61dc616a0e051332f44b89deb6b8a1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5824
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit 34e9243872)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5843
Spotted while investigating #18111, but likely does not fix it.
This matches the existing behavior of the runtime_loader heap.
(cherry picked from commit 5f40b96c35)
Change-Id: I85a60309585ffeec8ab558b899a7782e8da5a413
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5841
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
The files and formats are different for libnetservices and curl
backends, but now they are under the same directory whatever the
installed haikuwebkit version uses.
Change-Id: Iab87d5fd27ebea1fa0a8967a9802dfa2fb11240a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5835
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit 753349fb2e)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5839
The rest of the code does a memcpy(..., ..., min(11, strlen(...))
so clearly no NULL terminator is needed and 11 is the real limit.
Should fix #18074.
Change-Id: I6aea166899eab2bab9511ca52981ccc9172b6c17
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5823
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
(cherry picked from commit 0843085384)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5795
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
without this, my swift SF114-34 doesn't find the boot partition when booting on xhci, while it works on another port.
Change-Id: I141aa1497582860500991c44cdea81cff55756ed
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5792
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
* The if statements now "make sense"
* 1.4 GiB release images easily fit a "mini single layer DVD"
* Our source build is around 1.1GiB
* 200 MiB of "space" in our read-only image allows
a little room for live-media shenanigans
* Empty space is compressed anyway in release zip files
Change-Id: I5ad017e3f80d5977ca9604f5bf200684796fc7b9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5791
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Change-Id: Ib21a3fb8c26a25d84b0b3dd298c22618a53cb7d1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5790
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: Niels Sascha Reedijk <niels.reedijk@gmail.com>
* Userguide now provided from HaikuPorts.
* Python 3.7 -> 3.9.
* Lots of other version bumps.
(cherry picked from commit 96db3233c8)
Change-Id: Ica29a8b8e572763ff3eca960d67a6ba948bddb53
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5788
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
There's currently no way for an application to convert between view and
drawing coordinates with a drawing states stack without keeping track of
all the transformations itself, which is not very convenient for helper
or library functions.
Handle other spaces too, for good measure.
Change-Id: Ic8404a1c111e273fff1eebf2f9f59f58246b796c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5775
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit 241f109ccb)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5787
If nothing else for the Media codecs.
(cherry picked from commit 62bd88a64d)
Change-Id: Ief056668d98fb4f974189e70b729f92ec7b1684c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5786
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
This allows us to move the Gutenprint dependency there, too.
(cherry picked from commit fefa5edf96)
Change-Id: I7cead5949e4e7a201a213cf2cd323368b6028db3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5785
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
... even if no icon is present. Draw stripe w/o icon.
"After ... hrev56382 alerts ... with no icons appears without a
gray stripe, causing it to jump left and right."
Fixes #18033 for R1B4 Release Milestone.
Change-Id: I35acc07411cadd4b394d6dfa1957049280b6f4b3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5810
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit 369c7b11d2)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5783
Change-Id: Ib1aa2c3292c7c58dd7ac29d73f02d4bdece58687
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5805
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
C99 chapter 7.18.2, Limits of specified-width integer types:
"This expression shall have the same type as would an expression that is
an object of the corresponding type according to the integer promotions."
C99 chapter 6.3.1.1:
"If an int can represent all values of the original type, the value is
converted to an int; otherwise, it is converted to an unsigned int.
These are called the integer promotions."
Therefore, UINT8_MAX, UINT16_MAX, UINT8_C and UINT16_C should be signed.
This prevents building WebKit with -Werror.
Change-Id: Ib2a2c15acc2c761cccf8caa016c7ff163e3fdc0d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5806
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit 32a71a00aa)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5779
* Changes Haiku "development" logos to plain Haiku logos
in AboutSystem, Installer, Tracker Icons
Change-Id: I91696aa259411037f47b50eda354660c89374f47
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4111
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
(cherry picked from commit 79a172ef78)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5777
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
