Fix an issue where the scrollbar on user ratings
was not adjusting to the length of the ratings.
Change-Id: I690f4cbef0cdd88dd7540b47889166e0b3bf513d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7819
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Without this, a query term that does have an index but for which
the pattern starts with a wildcard (e.g. "*term*") is treated as having
a score of 0. That means that it is then dependent on the query order
as to whether or not the equation will run at all, since if all the terms
have a score of 0 but one has an index, placing that term first
will make the query run while any other would not.
Fixes #18672.
If we have a matching operator, we will replace the current item
with a new item, and we may need to process it again. For example,
in cases like "A||B||C", the first pass will turn this into "(A||B)||C",
and so we need to re-process the first item to get "((A||B)||C".
Fixes "Open with..." and some other things following the query parser
refactorings.
ModelMenuItem can throw exceptions if its Model fails to initialize,
and even though we pass a Model in directly, copying the Model
results in opening the underlying file again, which of course may
fail if something changed since our Model was created.
While at it, remove the return value, since it isn't used anywhere.
Should fix #18905.
This was missed in the update to Gutenprint 9.
Change-Id: Ie372a38d557e8f1506b27294b3d6699bb30f7fc0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7716
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
This fixes a regression introduced in 34fcf3d9ea.
That commit correctly adjusted the "pos" checks at the top of these
functions, but missed that there was a place in the loop where pos
is incremented. After the first increment, we would have a non-zero
pos, and so the new checks in the actual read/write routines would
return an error, meaning that only the first iovec was ever processed.
This fixes WINE following the aforementioned change.
The directory is created there, so we should also perform the
mount operation there. If we don't, the first boot of a new
Haiku image will not have the ramfs shared_memory, since of
course the kernel can't mount it at a nonexistent directory.
Mainly the ported OpenBSD drivers (where this was added in Haiku-specific
code), and then the few remaining drivers that are no longer supported
on FreeBSD.
* Add more if_{get|set}* routines, and move all copied directly from
FreeBSD into a fbsd_if.c file. Also clean up the header.
* DRIVER_MODULE macros dropped the "devclass" parameter.
In order to not break all existing drivers, use FreeBSD's
interim solution of compatibility macros.
This way, we won't run into stack overflow issues due to recursion.
Who would really need a FS query with more than 32 equations, anyway?
Fixes #18692.
Change-Id: Ieda401446d9cae2e56100ddbab08bebcc724b484
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7789
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
This way, we can handle parse trees of arbitrary depth without
running into stack overflows. Of course, evaluation is still
a problem...
While at it, use "const char*" everywhere, and also put the
query parser into an Init() function so we can return
more statuses than just B_BAD_VALUE.
Part of #18692.
Change-Id: Ib81e6545935ce484df10dfe36ca4ffcf2b3cd607
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7710
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
At present it just accepts query strings as command-line arguments
and prints the parsed query to the stream (or the error, if there
is one.)
Change-Id: I907380e370790ad9fb4d8f9406a18d359d0dcc2b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7709
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Rather than having individual directories for the tests. No
functional change intended.
Change-Id: Ie453eab2d7347cef4ea68a1e7793d01817e7da39
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7706
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Ideally should have no functional changes from the old one.
Change-Id: Id557d8fb069603221887447597ef0ffce5de07a6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7705
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Should not result in functional changes to packagefs and ramfs
queries behavior.
Change-Id: If361ca65de99d255e67f929c3442e0c20e39cdf4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7703
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Ensures that the new team has been reported to the debugger before
the main thread gets resumed. This allows the debugger to attach
to child teams as early as possible.
`fork` and `load_image` without `B_WAIT_TILL_LOADED` have always been
working as desired. This commit fixes the remaining case of
`B_WAIT_TILL_LOADED` by reporting before resuming the thread of
`runtime_loader`.
Change-Id: I7fd74606801c6ca5335d91c92f3157e6c6e66308
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7797
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Add `SIGNAL_DEBUG_THREAD` to the list of non-deferrable signals.
This allows debuggers to immediately install themselves and break
newly-forked children, as `libroot` requests signals to be deferred
around `_kern_fork`.
Change-Id: Ifc98c3ce4d394f187070a089a9be9fe665ee81d9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7796
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Using map[key] inserts the key in the map if it wasn't there, making it
non-empty.
Change-Id: I4404b896126aee202780b6e93e7c17c69ca8f34d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7787
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
When you add two crosshairs to measure pixels, it was a bit confusing to see:
1) x: 14 y: 11 x: 19
2) x: 33 y: 20 y: 9
Now it's:
➀ x: 14, y: 11
width: 19, height: 9
➁ x: 33, y: 20
"1)" and "2)" got replaced by dingbats numbers in a circle.
Change-Id: I7fd1b3bd7869a3251e15e249f74916150eef8218
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7724
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Adds a `signal` field to the `team_deleted` event. Since killing
signals like `SIGKILL` and `SIGKILLTHR` do not generate a
`signal_received` event, debuggers would only see a `team_deleted`
message with the `status` field set to 0. This makes debuggers like
GDB think that the debuggee has exited with a status code of 0.
To correctly report these signals, when a killing signal is sent
to a team, this signal is relayed to the main thread instead of
defaulting to just a `SIGKILLTHR` for both cases.
Change-Id: If69c9e2e4d87bfbd31f654f5cb6f696ac69ef777
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7756
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
