65990 Commits

Author SHA1 Message Date
Oscar Lesta
cccb5efb11 acpi_{ac,lid,thermal}: avoid SMAP related KDLs.
While these three worked just fine on my old Atom N450 based netbook,
all caused:

"PANIC: SMAP violation user-mapped address [...] touched from kernel [...]"

on a newer netbook with a Celeron N4020 CPU, before this change.

Side note / drivers status:

- acpi_ac works pretty decently on both machines.
- acpi_lid wrongly returns 0 until you close the lid for the first time.
  Reports correct values after that, but seems to cause power_daemon's
  event loop thread to peg one core to 100%.
- acpi_thermal readings are a mixed bag. Critical temp values Seem OK on
  both machines. Current value generally OK on the older machine, very wrong
  on the newer (reports 429496728.6 C).

Change-Id: Ia387a0bd5b21bdba1de0f0cd9ded814aa1ecdc26
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7432
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
hrev57600
2024-02-27 15:40:57 +00:00
Augustin Cavalier
8d35d95788 MultiAudioNode: Actually take input_channel_count into account.
USB audio input now works properly (as it has only 1 channel,
not 2.)
hrev57599
2024-02-26 17:05:26 -05:00
Augustin Cavalier
144f17d9e1 network/traceroute: Update to freebsd-current.
Same as ping, our IP modules don't support connect()/send().
Just use sendto().

Change-Id: I19e9874a5e92ac69f1935d3b192e4d652d201692
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7430
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
hrev57598
2024-02-26 21:24:46 +00:00
nep
9931e8eeee rgb_color: Add new APIs: Contrast(), IsLight(), IsDark()
- Remove perceptual_brightness
- Change implementation of rgb_color::Brightness() to the previous BPrivate::perceptual_brightness()
- Introduce convenience methods Contrast(rgb_color), IsLight() and IsDark()

Change-Id: Id677d4a32ce43d73bffecf9baf8cffaafb01a16d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7399
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
hrev57597
2024-02-26 20:24:25 +00:00
Jérôme Duval
d24476aaf0 device_manager: PCI_display is used for virtio gpu
the mapping was missing as noticed by Julian Harnath.

Change-Id: I8ea3420e1de543571daf82d8c16ec95ac3423826
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7431
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
hrev57596
2024-02-26 18:16:06 +00:00
Augustin Cavalier
1af693a23c ffmpeg: Increase accuracy of frame count computation.
BePac Deluxe checks the reported frame count against the actually
read frames count, and if the two do not match, it considers
this an error and bails out. So, we need to be as accurate as
possible here.

Additionally, fix Duration() for when start_time is nonzero,
and stay in integers where possible.

Fixes BePac Deluxe (again.)

Change-Id: Ic063fc15215dbfe3437d2430358227d7e2fe17fc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7422
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
hrev57595
2024-02-26 17:02:20 +00:00
Jérôme Duval
3bf4cdb73b network/ping: update to freebsd-current
* our ip modules don't support connect()/send(). Just use sendto().
* ping6 disappears, ping supports -4 or -6 to force IPv4 or IPv6

Change-Id: I1e982e354cc75d3a314c5bbbfffa0373e8f4d9af
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7427
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
hrev57594
2024-02-26 14:06:29 +00:00
Jérôme Duval
01dc1ea4cf libbsd: add strtonum(), nitems(), timespec operation functions from FreeBSD
Change-Id: I56b677b382d17a27d243b615de19bec10f3a2810
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7426
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2024-02-26 14:06:29 +00:00
Dan Gohman
b8caef6915 Change AT_FDCWD from -1 to -100.
Change the value of `AT_FDCWD` from -1 to -100. Either value should work,
since the Haiku implementation currently interprets any negative value as
`AT_FDCWD`, however -100 is preferable to -1 since -1 is used for error
return values.

fixes #18809

Change-Id: I53f273dd595c39ea9e4576b90adbbf7f555107cf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7423
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
hrev57593
2024-02-26 14:04:27 +00:00
Autocomitter
46bc2b6686 Update translations from Pootle hrev57592 2024-02-24 08:18:16 +00:00
Máximo Castañeda
118eb80985 app_server: update Symbols2 font name
It's changed in the version included in current noto package.

Fixes #18815

Change-Id: I6e2db902dff0f72f1a13ef5eafb2b9963e466e4a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7425
Reviewed-by: Máximo Castañeda <antiswen@yahoo.es>
hrev57591
2024-02-23 15:37:08 +00:00
Emir SARI
6a13b1d8e0 AboutSystem: add donation link
Change-Id: Iae14e28b9ba5436c8eab106d3413ad1dfae8ecbb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7372
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Emir SARI <bitigchi@me.com>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: humdinger humdinger <humdinger@mailbox.org>
hrev57590
2024-02-23 10:01:53 +00:00
Augustin Cavalier
8f34967728 raw_decoder: Pass errors back up the chain.
This way B_LAST_BUFFER_ERROR will actually be reported properly.
hrev57589
2024-02-21 16:19:53 -05:00
PulkoMandy
2a2e7ad562 doc/user: mention libnetwork and a bit of the filesystem hierarchy
Based on the feedback from Maya Posch in https://mayaposch.wordpress.com/2024/01/20/porting-nymphcast-to-the-haiku-operating-system/
Thanks for noting that the information was missing!

Change-Id: I4a9f709b17cb3a4a771f167b5af0fc83843ec5ad
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7406
Reviewed-by: Niels Sascha Reedijk <niels.reedijk@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
hrev57588
2024-02-20 12:14:51 +00:00
X512
d72ca12e19 app_server/BitmapManager: fix memory leak caused by missing token remove
`BTokenSpace::NewToken` put all allocated tokens into `fTokenMap` so
`BTokenSpace::RemoveToken` should be called for tokens that become unused to avoid infinite `fTokenMap` growth.

Change-Id: I0aee709234143ceaf4416d63b38fb2a26eb8f891
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7417
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
hrev57587
2024-02-19 14:30:21 +00:00
X512
0e268215f3 app_server/Screen: fix finalization order to avoid use after free
Change-Id: I41ba464a365be9449dfd47b2248746b9a338769e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7416
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
hrev57586
2024-02-19 14:29:37 +00:00
Augustin Cavalier
98166ebe04 network: Do not apply ethernet headers for loopback devices.
This reverts large portions of e2b57695fc3ec43cad099ab3dd93bdd99e052761
and all of 4e9653027d9094f4d57fd294d46ce6eb461b697f, and adjusts
the "tunnel" and "loopback_frame" handlers appropriately.

Initially, this logic was added so that libpcap continued working;
however, it seems that we can change some of the Haiku-specific code
in libpcap and have it continue to operate without requiring such
ethernet headers to be appended.

Fixes #18801.

Change-Id: Ie06908affde894ad1516fbc27e06298309a4e082
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7403
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
hrev57585
2024-02-18 00:50:59 +00:00
Andrew Lindesay
23cfed803a HaikuDepot : Fix Compile Warning
Change-Id: I210da9a98a7e97398c4a1789683392864b16f3ff
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7405
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
hrev57584
2024-02-17 21:32:04 +00:00
Autocomitter
025c6fb16e Update translations from Pootle hrev57583 2024-02-17 08:13:43 +00:00
Jérôme Duval
4d6b8a5796 app_server: Switch default UI font to Noto Sans.
fixes #18793

Change-Id: If53229acd6c00e1a800c6808f3f0261ae59d99bb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7400
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: Fredrik Holmqvist <fredrik.holmqvist@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Reviewed-by: nephele nephele <nep-git@packageloss.eu>
hrev57582
2024-02-13 12:01:31 +00:00
Jérôme Duval
0f792e577c BMenu: std::stable_sort uses a comparator function returning bool
thanks Madmax for the pointer.
fixes #18775

Change-Id: I1934c90a2976ce12c4aa8adb0205c48c239627d8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7401
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
hrev57581
2024-02-12 09:48:53 +00:00
Ilmari "ilzu" Siiteri
c1ad322d8f BKeyStore: Fix code to match documentation
Make secondary identifier mandatory on GetKey convience methods that secondary identifier as parameter (and not the secondaryIdentifierOptional bool)

Fixes #18776

Change-Id: I1ae3c9c0eb80a16e18a74835d7915dfa5efbb665
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7398
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: nephele nephele <nep-git@packageloss.eu>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
hrev57580
2024-02-12 09:45:42 +00:00
Autocomitter
41a9b30fc3 Update translations from Pootle hrev57579 2024-02-10 08:14:41 +00:00
Augustin Cavalier
bd34f534dd libroot: Disable -Werror and re-enable safeClone usage.
This code depends on the inline buffer being used at
the moment. Eventually we should refactor it, but for
now, just use the deprecated method.

Should fix regressions following ICU upgrade.
hrev57578
2024-02-09 13:02:01 -05:00
PulkoMandy
7804ba6054 ffmpeg: use new AVFifo API
Change-Id: I5712acc78087c00d066695eab6b2625316153f41
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7277
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
hrev57577
2024-02-09 13:08:40 +00:00
PulkoMandy
1774dd5ee9 ffmpeg: channels and channel_layout are deprecated
Use ch_layout instead

Change-Id: I6a07870eae42836d3fd993c253613bc0f33b1598
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7252
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
2024-02-09 13:08:40 +00:00
Oscar Lesta
eb2154fd47 acpi_ac & acpi_lid: return early if read position is not zero.
This avoids things like `cat /dev/power/acpi_{ac,lid}/0`
pegging CPUs to 100%, and the command never finishing.

Followed similar code already present on the acpi_thermal driver.

Change-Id: I5f13137716c36170608ab7e9dcbca628f48a138d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7397
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
hrev57576
2024-02-08 09:15:18 +00:00
Alexander von Gluck IV
cac7a2f426 icu: bump OS (and all dependencies) to ICU 74
* Non-x86 will likely break until they get an updated icu74
  build-package

Change-Id: I5762d14f848e1c4e9b837e1dea9c1a54efa8401d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7346
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
hrev57575
2024-02-07 18:14:48 +00:00
InfiniteVerma
c293445163 fs_shell: Add touch command.
Tested with btrfs and xfs but since create isn't supported yet in either, command fails with error: "Read-only file system".

Change-Id: Ice48680d289261a43e82a4189a2bc5619d4f5d9c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7371
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Niels Sascha Reedijk <niels.reedijk@gmail.com>
hrev57574
2024-02-07 08:06:46 +00:00
Emir SARI
fed199a7be Terminal: use multiplication sign instead of x
Change-Id: I800b765b8820d9ab48af735fb419207bf0e156bc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7374
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
hrev57573
2024-02-06 17:24:29 +00:00
Emir SARI
fce034d2ce notification_server: Use automatic percent formatting
This uses automatic percent formatting for the BStatusBar
progress text, instead of appending the sign manually.

Change-Id: I435220dd774822b60e376972a0f379a0e2b7359e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7375
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
hrev57572
2024-02-06 17:24:13 +00:00
Oscar Lesta
3e8df064cd usb_rndis: fix minor copy/paste and typo errors.
Change-Id: Ie75b763ec241a12bad107e1b48f89079c462c248
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7396
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
hrev57571
2024-02-05 07:54:24 +00:00
Trung Nguyen
4331338685 headers/os: Add name to spacing enum.
The `enum` containing `B_USE_DEFAULT_SPACING` and other members are
regularly used in default arguments.

Adding the name to this `enum` makes the header more generator-friendly
(see #6716).

Change-Id: I6676d2329bdb2152ccb37615345b97ba35f70563
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7377
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
hrev57570
2024-02-04 08:13:53 +00:00
Máximo Castañeda
1ad4f095e9 FileTypes ApplicationTypesWindow: fix UI updates
Fixes #5050 and the info staying empty after selecting a just
deselected item.

Change-Id: I519f7b260658e8e5a1671b854b0980d2fcde8352
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7370
Reviewed-by: Máximo Castañeda <antiswen@yahoo.es>
hrev57569
2024-02-03 20:41:25 +00:00
Augustin Cavalier
7f07b9f63d usb_audio: Disable for 2.0 devices.
It does not seem to work and causes high CPU usage.
hrev57568
2024-02-03 09:56:38 -05:00
Augustin Cavalier
34d116cc34 usb_audio: Fix -Wmisleading-indentation. 2024-02-03 09:56:14 -05:00
Jérôme Duval
a1bc100a78 listusb: fix MaxPacketSize, display length
audio: fix zero divide, add missing newline
Change-Id: Ia7d0ae6e403938291471185b14e07dc3e0f90ef4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7369
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
hrev57567
2024-02-03 14:52:45 +00:00
Autocomitter
6ce1856158 Update translations from Pootle hrev57566 2024-02-03 08:18:10 +00:00
Anant Verma
084e24d0bf docs/develop: minor improvements in the fs section
Change-Id: Ie94dbc1339facbee59080d85b6938f2c160eb05e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7368
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
hrev57565
2024-02-02 19:11:31 +00:00
PulkoMandy
a4ae49d573 Package server: turn down logging a bit.
This prints two quite long lists of packages that are mixed up with
other logs, making them annoying to read. It is also not very useful now
that the package server is working quite reliably.

Change-Id: Ibf9d5fc3eadc5cef42a78aea831e0a035e248de3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7366
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
hrev57564
2024-02-01 21:31:29 +00:00
Oscar Lesta
ed6d7787bf acpi_ac: fix driver build.
Change-Id: Ie698dfdb402bd2eb1ed24c0f760458782708eb3e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7365
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
hrev57563
2024-02-01 21:31:21 +00:00
PulkoMandy
e96dd82392 Screen preferences: some ui fixes
- When there is no refresh rate info available, disable the menu rather
  than showing "nan Hz"
- Rework the screen info tooltip generation, to avoid a confusing %s
  that was mistakenly moved to the end of the string in the French
  translation.

Change-Id: I4c29863a30c8c761021be57f8a2e2010709b16d5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7364
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
hrev57562
2024-02-01 21:19:19 +00:00
X512
e925863d95 kernel/DPC: allow adding callback to queue if already added (will do nothing)
It caused DPC list corruption when adding already added callback before
this change.

Change-Id: I81928795f91c6cf46fe3be4a8a042e07b9203161
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7363
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
hrev57561
2024-02-01 14:42:14 +00:00
Augustin Cavalier
123fa38638 usb_audio: Add to regular image.
Requires multiple media server restarts to switch
outputs to it, but that's a known media services
problem (#12777 and #12776.)

Input doesn't work quite right with the hardware
I've been testing with, but that's also a known
problem it seems (#9951). Meanwhile, output
seems to work pretty well, once it gets going.
hrev57560
2024-01-31 23:05:43 -05:00
Augustin Cavalier
3a9063ba08 usb_audio: Increase default buffer size to 2048 samples.
Ultimately this is just a minimum, in reality
we round up to the nearest page size and use
that to determine how many packets we queue
at once.
hrev57559
2024-01-31 22:44:13 -05:00
Augustin Cavalier
62ec294959 XHCI: Don't double-report completion status for isochronous transfers. hrev57558 2024-01-31 14:49:00 -05:00
Augustin Cavalier
b785b0cf1c usb_audio: Report callback errors to syslog.
That way they don't just get lost.
hrev57557
2024-01-31 14:39:33 -05:00
Augustin Cavalier
f4e363ee29 XHCI: Report ring overrun/underrun (isochronous errors) back to drivers.
Since transfer status is reported via the packet descriptors, we
can report the endpoint status through the callback status.

Reduces syslog spam when using the USB audio driver.
hrev57556
2024-01-31 14:36:52 -05:00
Augustin Cavalier
be3ce6d7e9 USB: Make "buffer error" reporting consistent.
This error means that the controller failed to read or write data
to/from system memory fast enough. As a result, we should report it
as READ_ERROR/WRITE_ERROR, rather than something that sounds like
an error with the device itself.

Then, make BABBLE reporting consistent: this is a data overrun/underrun
of the device itself, not the buffers passed to the controller.
This then leaves B_DEV_FIFO_OVERRUN/UNDERRUN unused, and thus usable
for reporting ring overrun/underrun on isochronous transfers.

The API documentation already described DATA_OVERRUN/UNDERRUN basically
like they were babble errors, while FIFO_OVERRUN/UNDERRUN are
currently described as "internal errors" at present. No driver actually
checked for these.
2024-01-31 13:55:40 -05:00
Augustin Cavalier
22f0158a25 XHCI: Move error status conversion to its own function and reuse it.
Also add COMP_MISSED_SERVICE -> B_DEV_TOO_LATE while at it.
2024-01-31 13:47:34 -05:00