6d1f6cad34
On my development VM, there were over 300,000 calls to malloc() from EntryAttributeHandler::HandleAttribute() alone, which had the most out of any AttributeHandler, but the others were still significant (over another 10,000 at least.) On systems with more packages and more attributes, there would be of course more calls to malloc(). Since the Handlers are allocated and freed in a "stack"-like configuration, we can use a simple "bump" allocation strategy with the AttributeHandlerContext to avoid calling malloc() at all. In my testing, the most memory that was used appeared to be around 2 KB or so (and the smallest was 216 bytes), so a single slab should suffice for this. AttributeHandlerContext seems to be created/destroyed around 530 times during the boot process on my test machine; allocating and freeing the allocator's slab page that many times should be negligible (allocations that large still go through the block allocator.) Performance-wise, the total time we spend with AttributeHandlerContext objects "alive" goes from around ~172ms to ~156ms. So, not as much an improvement as one might hope, but that just goes to show that our kernel malloc() is pretty efficient. And this change will also keep short-lived objects off the heap during a period when we are allocating many long-lived objects, anyway. Change-Id: I810888434aad788511f2af30143335009b34ee78 Reviewed-on: https://review.haiku-os.org/c/haiku/+/8230 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.