mirror of
https://review.haiku-os.org/haiku
synced 2025-01-31 18:56:49 +01:00
6d1f6cad34
On my development VM, there were over 300,000 calls to malloc() from EntryAttributeHandler::HandleAttribute() alone, which had the most out of any AttributeHandler, but the others were still significant (over another 10,000 at least.) On systems with more packages and more attributes, there would be of course more calls to malloc(). Since the Handlers are allocated and freed in a "stack"-like configuration, we can use a simple "bump" allocation strategy with the AttributeHandlerContext to avoid calling malloc() at all. In my testing, the most memory that was used appeared to be around 2 KB or so (and the smallest was 216 bytes), so a single slab should suffice for this. AttributeHandlerContext seems to be created/destroyed around 530 times during the boot process on my test machine; allocating and freeing the allocator's slab page that many times should be negligible (allocations that large still go through the block allocator.) Performance-wise, the total time we spend with AttributeHandlerContext objects "alive" goes from around ~172ms to ~156ms. So, not as much an improvement as one might hope, but that just goes to show that our kernel malloc() is pretty efficient. And this change will also keep short-lived objects off the heap during a period when we are allocating many long-lived objects, anyway. Change-Id: I810888434aad788511f2af30143335009b34ee78 Reviewed-on: https://review.haiku-os.org/c/haiku/+/8230 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: waddlesplash <waddlesplash@gmail.com>