visualboyadvance, mark broken due to unsafe source (#3782)

* visualboyacvance, remove in favor of mGBA

games-emulation/visualboyadvance/patches/Makefile.am.patch

@@ -1,91 +0,0 @@
-diff --git a/src/sdl/Makefile.am b/src/sdl/Makefile.am
-index bcc9f92..ba6db7a 100644
---- a/src/sdl/Makefile.am
-+++ b/src/sdl/Makefile.am
-@@ -1,7 +1,5 @@
- bin_PROGRAMS = VisualBoyAdvance
- 
--noinst_PROGRAMS = TestEmu
--
- VisualBoyAdvance_SOURCES = \
- 	SDL.cpp			\
- 	debugger.cpp		\
-@@ -79,78 +77,6 @@ VisualBoyAdvance_LDADD = @VBA_LIBS@ @SDL_LIBS@
- 
- VisualBoyAdvance_DEPENDENCIES = @VBA_LIBS@
- 
--TestEmu_SOURCES = \
--	TestEmu.cpp		\
--	debugger.cpp		\
--	debugger.h		\
--	../2xSaI.cpp		\
--	../AutoBuild.h		\
--	../Cheats.cpp		\
--	../Cheats.h		\
--	../EEprom.cpp		\
--	../EEprom.h		\
--	../Flash.cpp		\
--	../Flash.h		\
--	../GBA.cpp		\
--	../GBA.h		\
--	../GBAinline.h		\
--	../Gfx.cpp		\
--	../Gfx.h		\
--	../Globals.cpp		\
--	../Globals.h		\
--	../Mode0.cpp		\
--	../Mode1.cpp		\
--	../Mode2.cpp		\
--	../Mode3.cpp		\
--	../Mode4.cpp		\
--	../Mode5.cpp		\
--	../NLS.h		\
--	../Port.h		\
--	../RTC.cpp		\
--	../RTC.h		\
--	../Sound.cpp		\
--	../Sound.h		\
--	../Sram.cpp		\
--	../Sram.h		\
--	../System.h		\
--	../Text.cpp		\
--	../Text.h		\
--	../Util.cpp		\
--	../Util.h		\
--	../admame.cpp		\
--	../agbprint.cpp		\
--	../agbprint.h		\
--	../arm-new.h		\
--	../armdis.cpp		\
--	../armdis.h		\
--	../bios.cpp		\
--	../bios.h		\
--	../elf.cpp		\
--	../elf.h		\
--	../expr-lex.cpp		\
--	../expr.cpp		\
--	../expr.cpp.h		\
--	../exprNode.cpp		\
--	../exprNode.h		\
--	../hq2x.cpp		\
--	../hq2x.h		\
--	../interp.h		\
--	../lq2x.h		\
--	../memgzio.c		\
--	../memgzio.h		\
--	../motionblur.cpp	\
--	../pixel.cpp		\
--	../remote.cpp		\
--	../scanline.cpp		\
--	../simple2x.cpp		\
--	../thumb.h		\
--	../unzip.cpp		\
--	../unzip.h
--
--TestEmu_LDADD = @VBA_LIBS@ @SDL_LIBS@
--
--TestEmu_DEPENDENCIES = @VBA_LIBS@
--
- AM_CPPFLAGS = \
- 	-I$(top_srcdir)/src		\
- 	-DSDL				\

games-emulation/visualboyadvance/patches/Util.patch

@@ -1,26 +0,0 @@
-diff --git a/src/Util.cpp b/src/Util.cpp
-index 9e3b7d9..6ab1614 100644
---- a/src/Util.cpp
-+++ b/src/Util.cpp
-@@ -86,8 +86,12 @@ bool utilWritePNGFile(const char *fileName, int w, int h, u8 *pix)
-     fclose(fp);
-     return false;
-   }
-+#if PNG_LIBPNG_VER_MAJOR >= 1 && PNG_LIBPNG_VER_MINOR >= 4
- 
-+#else
-   if(setjmp(png_ptr->jmpbuf)) {
-+#endif
-+  if(setjmp(png_jmpbuf(png_ptr))) {
-     png_destroy_write_struct(&png_ptr,NULL);
-     fclose(fp);
-     return false;
-@@ -992,7 +996,7 @@ void utilWriteData(gzFile gzFile, variable_desc *data)
- 
- gzFile utilGzOpen(const char *file, const char *mode)
- {
--  utilGzWriteFunc = (int (ZEXPORT *)(void *,void * const, unsigned int))gzwrite;
-+  utilGzWriteFunc = (int (ZEXPORT *)(gzFile,const voidp, unsigned int))gzwrite;
-   utilGzReadFunc = gzread;
-   utilGzCloseFunc = gzclose;
- 

games-emulation/visualboyadvance/patches/configure.in.patch

@@ -1,12 +0,0 @@
-diff --git a/configure.in b/configure.in
-index 159bf87..1ad2fac 100644
---- a/configure.in
-+++ b/configure.in
-@@ -64,6 +64,7 @@ dnl Checks for libraries.
- AC_CHECK_LIB(z, gzopen,
-   , AC_MSG_ERROR([*** Cannot compile without zlib.]))
- AC_CHECK_LIB(pthread, pthread_yield)
-+AC_CHECK_LIB(network, socket)
- 
- PKG_CHECK_MODULES(LIBPNG, libpng)
- CPPFLAGS="$CPPFLAGS $LIBPNG_CFLAGS"

games-emulation/visualboyadvance/visualboyadvance-1.8.recipe

@@ -1,66 +0,0 @@
-SUMMARY="A Game Boy Advance Emulator"
-DESCRIPTION="
-VisualBoyAdvance is a Game Boy Advance emulator which runs your prefered ROMS."
-HOMEPAGE="http://vba.ngemu.com"
-COPYRIGHT="2002-2004 Forgotten"
-LICENSE="GNU GPL v2"
-REVISION="1"
-SOURCE_URI="git://git.debian.org/git/pkg-games/visualboyadvance"
-SOURCE_DIR="VisualBoyAdvance-1.8"
-PATCHES="
-	Util.patch
-	Makefile.am.patch
-	configure.in.patch
-	"
-
-ARCHITECTURES="!x86_gcc2 x86 ?x86_64"
-SECONDARY_ARCHITECTURES="x86"
-
-PROVIDES="
-	visualboyadvance$secondaryArchSuffix = $portVersion
-	app:visualboyadvance$secondaryArchSuffix = $portVersion
-	"
-REQUIRES="
-	haiku$secondaryArchSuffix
-	lib:libpng$secondaryArchSuffix
-	lib:libsdl$secondaryArchSuffix
-	lib:libsdl_mixer$secondaryArchSuffix
-	lib:libz$secondaryArchSuffix
-	"
-
-BUILD_REQUIRES="
-	haiku${secondaryArchSuffix}_devel
-	devel:libpng$secondaryArchSuffix
-	devel:libsdl$secondaryArchSuffix
-	devel:libsdl_mixer$secondaryArchSuffix
-	devel:libz$secondaryArchSuffix
-	"
-BUILD_PREREQUIRES="
-	cmd:aclocal
-	cmd:autoconf
-	cmd:gcc$secondaryArchSuffix
-	cmd:ld$secondaryArchSuffix
-	cmd:libtoolize
-	cmd:make
-	cmd:nasm
-	cmd:pkg_config$secondaryArchSuffix
-	"
-
-BUILD()
-{
-	libtoolize --force --copy --install
-	autoreconf -i
-	runConfigure ./configure --enable-c-core --disable-profilling --without-mmx
-	make
-}
-
-INSTALL()
-{
-	cd src
-	GAMEDIR=$appsDir/Visualboyadvance
-	mkdir -p ${GAMEDIR}
-	cp VisualBoyAdvance.cfg ${GAMEDIR}
-	cp sdl/VisualBoyAdvance ${GAMEDIR}
-
-	addAppDeskbarSymlink ${GAMEDIR}/VisualBoyAdvance
-}