Freeciv: Recipe cleanup, fix strict build errors (#12087)

games-strategy/freeciv/freeciv-3.1.4.recipe

@@ -11,14 +11,13 @@ you do not need to own Civilization to play Freeciv."
 HOMEPAGE="http://www.freeciv.org/"
 COPYRIGHT="1996-2025 The Freeciv Team"
 LICENSE="GNU GPL v2"
-REVISION="2"
+REVISION="3"
 SOURCE_URI="https://downloads.sourceforge.net/sourceforge/freeciv/freeciv-$portVersion.tar.xz"
 CHECKSUM_SHA256="14999bb903c4507cc287d5a8dd1b89eee623bb41b4e01e0836567fb5f13296e4"
 PATCHES="freeciv-$portVersion.patchset"
 ADDITIONAL_FILES="
 	freeciv.rdef.in
 	"
-POST_INSTALL_SCRIPTS="$relativePostInstallDir/freeciv-postinstall.sh"
 
 ARCHITECTURES="all !x86_gcc2"
 SECONDARY_ARCHITECTURES="x86"
@@ -107,7 +106,9 @@ INSTALL()
 {
 	make install
 
-	rm -f $libDir/*.a $libDir/*.la
+	mv $prefix/share/* $dataRootDir
+	rmdir $prefix/share
+	rm -rf $libDir/*.a $libDir/*.la $dataDir/{applications,icons,metainfo,pixmaps}
 
 	mkdir -p $appsDir
 	ln -s $commandBinDir/freeciv-sdl2 $appsDir/Freeciv
@@ -125,7 +126,5 @@ INSTALL()
 
 	addResourcesToBinaries freeciv.rdef $appsDir/Freeciv
 
-	addAppDeskbarSymlink $appsDir/Freeciv
-	mv $prefix/share/* $dataRootDir
-	rmdir $prefix/share
+ 	addAppDeskbarSymlink $appsDir/Freeciv
 }