We should investigate why there are anonymous or unset attributes. But
at least let's not KDL because of it.
Fixes #16038.
Change-Id: Ifd49475e25ce8dcc3e98bc22df81f0e4f493f915
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2710
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit 59588089e7292abaa537d9d6da9b537e4caf942f)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2712
Unfortunately this will rule out 15-samples MOD files, but it fixes #16035.
Change-Id: If3634c8ef4228ebe7ec5f8eac9f142ffff2ca30c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2703
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit e44ab82455291e4c621e92efa9e4c42e4eda8ee3)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2706
* beta1 -> beta2
* rotate the "beta2" stamp as it was remarked before that the stamp
going 'uphill' is supposed to have better vibes than 'downhill' as
it's now...
Change-Id: I60a60a1ba36ac11817294c91deecc555582e039e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2697
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit 6bd96c5234def1ed791026efaf7cb32b5fa4bd92)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2700
The way this rule works is it check two things:
- The document starts with "<?xml", "<svg", or "<DOCTYPE"
- In the first 512 bytes there is either an SVG or DOCTYPE SVG opening
tag (both casze insensitive)
This should allow to correctly detect most SVG files, all while not
misdetecting other things (for example xhtml with a nested SVG) too
easily. It's difficult to be completely accurate with just a sniffing
rule.
Change-Id: I66d6e21ff694c4a6349989db2685dffb44ef5767
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2681
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
(cherry picked from commit 0f161e01367b0909b83e878ca282588823976056)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2694
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Otherwise, the entire list will be scanned for row widths, which
is extremely slow with thousands of items, and may not be what
the user wants anyway, if they have set specific column sizes
which are larger/smaller than that.
Helps with #16012 and #15889 considerably.
(cherry picked from commit 9585fabd612d4c823ed9f9d20b15c4c12411895a)
Change-Id: I7414c2f0f69b1d791adf9d8186dbf1ff95a126fa
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2688
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
The size limits are already the minimum/maximum for all views,
not just the current one, so we do not need to recompute them
when the layout is invalidated due to an item switch.
Fixes #14675, and other performance issues on switching tabs
in layouted BTabViews, among other things.
Change-Id: I55bfe4ddb8c8a79c634634cfc27113205a790c42
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2677
Reviewed-by: Andrew Lindesay <apl@lindesay.co.nz>
(cherry picked from commit 9cfe1443266e511b0a9fe9c8514655f280cf1b63)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2678
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Stop when we have a solution that is within 1px of accurate. Since tab
width are rounded to the nearest pixel anyway, there is no need to
compute further, and this could otherwise never converge due to rounding
errors.
Fixes #15944.
Now Pulse can be both in a normal window and in DeskBar at the same
time. The Replicant starts the app if needed to show the settings and
about box there, instead of showing the window in the DeskBar process.
Fixes #6901
Change-Id: I3cede07df9216c54e4ad97b50618d42c2fa5e12e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/83
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit e04f6f31b08f57dfd8a75d3f399666b76f23b22a)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2659
For historical reasons, the package kit has an "url" field that is not
actually meant to be used as an URL. Rename it in the API and user
facing output as "identifier" to make it clear what the file is used
for. This change preserves the "url" key in on-disk and online storage
(hpkr files, stored settings, etc) in an attempt to not break anything.
Fix one remaining misuse of the "url" field as an URL in
get_package_dependencies.
Add an unit test showing that BUrl does parse "tab" URIs properly (there
is just a protocol and a path segment).
Change-Id: I339ce526e5798d42d78ae650855d7e988dbb4a1a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2620
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
The font antialiasing settings make the font rendering change. It can
make strings longer or shorter, and this can result in the menufield
being moved by a few pixels. So add a safe margin around the menu field
to accomodate for it.
Fixes #13039.
Change-Id: I73de08b747dc8cade58bcc674dd4f94fb6a9f9eb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2630
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit 2b4c59635fc6ac5e3551d1f154141ff72b3b2fc7)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2637
It may be the case that a file is largely ASCII with few UTF-8 or
similar characters (typically, english text mentionning names in other
languages). It turns out 2 kilobytes of text is not enough for a safe
guess in that case.
Fixes #14674
Change-Id: Id894bebb821c22a17b776a71822d011abc795dea
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2628
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit 8bb5fd243743acca90bc9fc0a3c03abee5f674f5)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2636
The idea of the settings file is to have commented-out non-default
values. So that uncommenting a line is enough to toggle a boolean
feature.
Change-Id: I38dece9e6359429f3806da3cb6a65e30faacf7bb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2614
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
- Move Kyle Ambroff-Kao to the maintainers
- Add Diver, Vidrep and Luroh as bug triaging and testing team (your
work deserves more credit, thanks a lot!)
- Move Koki back into "past website/marketing team"
Change-Id: I3f198277804aaa2dedf0551ced65e5f94393f3ea
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2624
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit 566914fad4e1fdce4923bb0b2dc5bcf278232c0b)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2633
This reverts commit 450208975b6a059e645e8c2b4a77c346b9b03b71.
The alert is not appropriate because applications cannot intercept it.
Fixes #15734
Change-Id: I5be98367ae615a572193406a559e5d34617e445c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2626
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit fc86ef2cef7b440577edddbd6db02399a423a1d6)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2632
- Main problem was that lastItem was accidentally used outside of a NULL check
- Also cleanup initialization and reset of fLastClickedItem (it is now valid
from mousedown on an item to either mouseup, or when the team dies)
Fixes #15991
Change-Id: Ia511de1922675afea6a2d88d088dc09168e7f7aa
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2616
Reviewed-by: X512 <danger_mail@list.ru>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
It does have a performance impact (as it serializes all VMCache
creations), and it is not that useful, so move it to KDEBUG_LEVEL_2
so that the beta releases (on KDEBUG_LEVEL_1) are not affected
by it.
(The nightlies are on KDEBUG_LEVEL_2, so this will not affect
them.)
Change-Id: Iab35d58f9d210651e3fd9027b75ea27a7a6928e5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2612
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
(cherry picked from commit cac30e419035ddd49010a81c59f65b68e4919ce1)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2613
This reverts hrev54120 and instead adds the commonly supported
MAP_NORESERVE flag to request overcommit.
Using PROT_NONE for overcommit is problematic as the protection of
individual pages can still be changed via mprotect to make them
accessible, but that won't change the commitment. An application
using such a pattern may then unexpectedly run into out of memory
conditions on random writes into the address space.
With MAP_NORESERVE the overcommit can explicitly be requested by
applications that want to reserve address space without producing
memory pressure.
Change-Id: Id213d2245c5e23103e8e0857f7902e0cd8a2c65d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2611
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
A minimal layout cleanup for beta2. Further changes were proposed in a
separate ticket, #9781, maybe for later.
Fixes #9780.
Change-Id: I1f66d808bd2cea683aa9f3a905cdf5717f1824ef
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2607
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
