It's not allowed to enable the screen before having set a mode. At least
in the case of the intel_extreme driver, this creates some problem. Move
the call just a bit later in the init process, where the mode is already
set.
Fixes #17163.
Change-Id: Iaa665f0edc15316890032f1a5928f33634dc8749
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4362
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: François Revol <revol@free.fr>
Reviewed-by: <BeagleJoe13@gmail.com>
(cherry picked from commit 1c88f77dccc78e8a59d74f767cfc28d69bc52f2c)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4338
pointed out by cppcheck
Change-Id: Idf81666674c881ca9e00bf3985ed0dcf928c19d5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4220
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
(cherry picked from commit cf4ce7e38b38ded05776a0397a38488f8e8308f7)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4257
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Previous code from hrev55212 was triggered on every workspaces change.
Fixes #17078.
Change-Id: Ib914fc5b909b24b71ca79a0107e0f719917ecda7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4184
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
HTTP errors can have some content sent with them (a message to display
to the user, usually). The package kit would not ignore this and append
the content to the end of the downloaded file. This could result in a
file larger than the expected size, and in that case, it would keep
growing infinitely by adding more error messages to it.
Also add some more specific error messages for some HTTP codes, in
particular, "invalid range" which is likely to happen if something goes
wrong with range requests. Now this case will be detected and the
download will stop.
Change-Id: I18927f361235e9f72a5701c1bd7977abda9e21ad
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4210
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
(cherry picked from commit fa1e07fa7a774d0504c21b37ee051e90e1816747)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4182
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Integer overflow caused bitmap buffer creation of wrong size and out of
bounds access when large bitmap was created. Now allocation failure is
reported for large bitmaps.
This prevents app_server from crashing while playing YouTube in WebPositive.
Fixes #16489.
Change-Id: I297aa6e3b79b32a486d297f1239a1fd4397a8a36
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4209
Reviewed-by: Sergei Reznikov <diver@gelios.net>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
(cherry picked from commit 2641b03c91ea1102587c75d57fe506a54217dd5c)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4181
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
ICU's Locale::getDisplayName fills in the locale's name in the form
"language (country, variation)". We are interested in the country here.
Fixes #17081
Change-Id: Icb810dbe2c486d95251d4d06a48dfe3a000fa968
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4206
Reviewed-by: humdinger <humdingerb@gmail.com>
(cherry picked from commit ae56997857d47d5010a3096655cca0a3467264e2)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4180
Reviewed-by: Máximo Castañeda <antiswen@yahoo.es>
Fixes #17069
Change-Id: I42f6ecbad57d7d6b21bfbde2645f1d7112d650b8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4200
Reviewed-by: Jessica Hamilton <jessica.l.hamilton@gmail.com>
(cherry picked from commit 66d04700359c8d4bf921baa94edd9f827214b811)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4177
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Pose::CalcRect() assumed top is at icon top in mini-icon mode. This
is not true for larger font sizes where the top of the text is above
the top of the icon. Calculate top and bottom based on font and icon
size matching the calculation in TextWidget::CalcRectCommon(). This
fixes a highlight redraw bug in mini icon mode at larger font sizes.
Push Edit name right 2px to match label position (in mini-icon mode.)
Round to integer to help with 1px off bug. Edit name box is still off
by 1px from the label for some font families and sizes.
Change-Id: Ibba897d6f3c7a879631adedada5cd59d2071191a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4204
Reviewed-by: John Scipione <jscipione@gmail.com>
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
(cherry picked from commit 50107f9f2b2cbf394142f18f410c68db3a8ad418)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4178
EFI System Partition was the last remaining holdout for mtools usage.
Change-Id: I988f82a2f4318f2f90ec1efb80f7ff5c8908aff7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4140
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
(cherry picked from commit 977a873ab2a46b60e1968223f18bd117a10803ef)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4027
Reviewed-by: Jessica Hamilton <jessica.l.hamilton@gmail.com>
Reviewed-by: Fredrik Holmqvist <fredrik.holmqvist@gmail.com>
* platform_add_block_devices() is a no-op, as efi already
provides all devices to the generic loader code.
* remove iterator.Remove() in platform_get_boot_partitions()
as the simplified devices scan no longer duplicates
partition entries.
Fixes #17051
Change-Id: I38789b069e1be9b18312e2455bc91e6195114599
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4160
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
(cherry picked from commit 2123a7ccb48491429a836d584d7f9cbb5ca12900)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4176
Reviewed-by: Jessica Hamilton <jessica.l.hamilton@gmail.com>
* Haiku now consumes right at 700 MiB on x86_gcc2h
after the webkit update.
Change-Id: Ia41a3e6252190e73feaa49ebe7c58ef4c80df4dc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4161
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
(cherry picked from commit 12bb3886c550863d5dd09d73cb770f5ba105e432)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4031
This also keeps the functionality of hrev53848, which simplifies the
list of disks searched for bootable partitions; however, it maintains
the previous behaviour of platform_get_boot_partitions that continues
to iterate over a list of possible boot partitions, which should
allow finding a bootable BFS partition better in more circumstances.
Particularly, there are numerous reports of the UEFI loader entering
the boot menu despite it finding a bootable partition, which this
should address.
EFI's device_contains_partition is also structured such that it
compares the disk GPT table of the partition the loader is
querying of the EFI disk's GPT table, in the case that there are
multiple disks, as the most reliable method of comparison, with
a generic fallback for non-GPT disks, which will be less reliable.
This reverts commit 0d932a49ada8af6314cd3f20c3f597143f1f555d.
Change-Id: I5fac8608035d56b8bb4dc6c3d495ec6db42fa9b7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4149
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
(cherry picked from commit 62f80a2a71f25302936b713842a38e8bc293b073)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4028
Screen may be turned off if video card is not supported by firmware and boot
loader.
Change-Id: Ie60fc00da281ec3781084dd97466a68b885fde7b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4114
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
(cherry picked from commit cc265c1482e8e7748cdb06bf0962f4475d789802)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4026
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
We were incorrectly reporting a B_IO_ERROR for these requests because we
could not read the content after the headers. There is no content in
these cases.
Add an unit test for both HEAD and 204 status, checking that there is no
content and the headers are correct.
Fixes #16885.
Change-Id: I98fefc5c604253bb2545b50395b7af9f8834def0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4142
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Niels Sascha Reedijk <niels.reedijk@gmail.com>
(cherry picked from commit 3ca5eec002c54d7623ab85b66254ec2f31851cc9)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4025
- New text/markdown MIME type was added according to IANA registry.
- MIME types gained new extensions that weren't previously included.
- Resource definition files will now open up with Pe by default.
- text/x-vcard was renamed to text/vcard, as it's now a registered IANA MIME type.
- text/x-source-code had its sniffing rules increased in priority,
so that it would get precedence over text/plain and its own sniffing rules.
Change-Id: I28af24de8c0e96ef39dfc67703a0884e8d4c842e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4109
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
(cherry picked from commit 74f28747a23711ca0800e47f4bc892a1f0a98cde)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4018
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
the checksum assumes the full inode block.
Change-Id: I60ef5d0b769750107b7e104709edff95beee8085
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4118
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
(cherry picked from commit 842a1538a6b726ba535497d7bea7756dc191f90c)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4020
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
The code allowed execution to continue as soon as the "command inhibit"
bit was cleared. This is incorrect: we need to wait for a command result
(either command complete, or timeout) to be available before continuing.
This should fix #17031.
Change-Id: I8f3fe60c2e47582b399952b19c05c6ed2161afd7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4121
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
(cherry picked from commit ab9943450324a0401ec2e9a0030de6a17347f51b)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4023
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
* Off-by-one error copying the string.
* As per the spec, return the buffer length for the string when passed a
null pointer and 0 length.
Fixes https://github.com/haikuports/haikuports/issues/5821
Change-Id: Ic421f26db00f9820c6a617375e39f7341cd5ebc1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4110
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
(cherry picked from commit 4c23dfb3a364519b5caa61b14fe1157d5ee3411e)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4019
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
which need special support.
Change-Id: I576f6b78dfd4d9213a7da073adf4c664aeea18b4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4120
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
(cherry picked from commit 094ea67748567e26d7091a4d537f3e984c8ebde9)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4021
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Fix part of #17023
* Update default server to "gnudb.gnudb.org:80".
* Add "/" to command footer to work with gnudb.
Change-Id: I363ca919d971e96ba27476a56ca06b4e8fa99171
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4112
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
(cherry picked from commit 0071f2c47796091551aa3f0bcd09f6443e7fc5f3)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4017
