All callers just set it to "0", and it's not clear
that it's actually useful outside vnode_path_to_vnode's
own usage of it, anyway.
Makes the two function variants more distinct and harder
to accidentally mix up.
Just like the kernel has.
Put in the same file with the user_memcpy wrapper,
and rename the file to "misc.cpp" (which is a name
also used in libroot_build for a file containing
miscellaneous wrapper functions.)
Otherwise we could cause leaks.
Most of the time this check should be optimized out,
as most uses of AutoDeleter don't invoke SetTo. But
it would have caught some bugs in the VFS refactors
(which wound up being cancelled out by later commits
anyway, but this would've exposed them.)
Just invoke debugger(), which calls the kernel
debugger when compiled in kernel mode. And define
debugger() inline in this header if OS.h is not
included to avoid namespace pollution.
Do not fail silently if the saved fFilePanelPath doesn't exists, or
otherwise can't be used.
Default to B_USER_DIRECTORY, and print the issue to stdout at least.
Change-Id: If08720fa0d6d91bb7bd4b5a922be7136012aae95
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7536
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
hrev57608 changes conflict with the use of left-option-as-meta (#18832).
Avoid that by using:
- CMD+left/right for switching tabs, and Shift+CMD+left/right for moving them.
- Ctrl+Shift+up/down for one-line-at-a-time scrolling.
Should fix #18832, but I'm still not happy with those scrolling shortcuts.
Also: removed some `(mod & B_COMMAND_KEY)` checks that don't make much sense
on `BView::KeyDown()`. They were there since hrev26038.
Change-Id: I8d276d18057d309b786f0480c27071cf084b38ef
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7495
Reviewed-by: humdinger humdinger <humdinger@mailbox.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
* Update bash to a less-buggy working native build.
* Add file for python3
* Add readline for bash
* Update xz_utils to a working native build.
Change-Id: Iedfcb8277b242ea43a2fd870850057429c6b09e0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7528
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
While AVPacket itself contains other fields, the
important ones are all static, and fit in 64 bytes.
So we can put them into the chunk media header directly
and then grab them again in AVCodecDecoder.
With that passed through, we can then use the
best_effort_timestamp, as it's more likely to be
correct.
Change-Id: Ied82137694f1307d4dcb177f3f9a7cb6b798461a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7525
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
acgcc.h defines ACPI_FLEX_ARRAY as struct containing empty struct
and flexible array member. This leads to unintended consequences when
it is compiled as C++ code, because empty struct in C++ is not zero-sized.
This breaks querying interrupt numbers in acpi_irq_routing_table.cpp.
Apply fix from upstream: bce7c55e99
Change-Id: I8cadbacd564660b0fad9addd2ce58f39c6f45ac2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7516
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Aside from leaking resources it caused a race that could segfault
DPC thread when its stack was unmapped.
Change-Id: If6943e7fd834cac8f9807b85ecbb77e227f47a94
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7512
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Additional tests for parsing the language from
an ID.
Change-Id: Ia22b5e528a0dd9bdf10f3f060b01429fc95a799b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7517
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Noticed by Joachim Mairböck after I hastily merged change 7402.
Also add named variation instance selection for fonts loaded from memory
areas like there already is for files.
Change-Id: I76de22181dc39559956c25987165be2f8a8c4a37
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7493
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
It's not used for anything by the OS but userspace might want
to use it for its own purposes.
Change-Id: Icda4bcd6de9d68596555e81293c8bd075f80a2a4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7511
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Branch inside exception vector slot is emitted through PLT veneer,
which clobbers x16 and x17.
Making the function static removes the veneer, and fixes the problem.
Change-Id: If8810999675b6e36926be9806e23a78b7e5c0f10
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7509
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
This is no-op for 32 bit platforms because `int32` is defined as `long` there.
Change interrupt vector number from 64 bits to 32 bits for 64 bit platforms.
Change-Id: I52d1ad616cab16488804e9733c7afaf772a670ba
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7507
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
It has been replaced by Noto as the default font for CJK characters and
is not referenced anywhere else anymore.
Change-Id: I9eb706531deb44395d71e0a04b0ec5e2f2dea230
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7499
Reviewed-by: nephele nephele <nep-git@packageloss.eu>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Was giving:
"warning: long int format, different type arg (arg 2)"
On beta4 32 bits.
Change-Id: Ifd50eaff8d40bf31d24db4441b15aad5590b8c95
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7502
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: nephele nephele <nep-git@packageloss.eu>
This is now managed in another class entirely.
Change-Id: Ib415b17b5785b9077b42146fff97d85184b23a67
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7478
Reviewed-by: nephele nephele <nep-git@packageloss.eu>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
HDS is soon going to be enhanced to deal with more than
just the two-character ISO language codes that it
currently supports. The logic in HD is currently expecting
that HDS will only supply these two character codes. This
change is about making adjustments to be able to cater to
any ICU language IDs from HDS.
The naming in HDS is still going to continue to use the
terminology that it currently does; it will call the
identifier for a language a "natural language code". The
HD source will instead reflect the nomenclature of ICU
and call the same thing a language ID.
Change-Id: Ib138c2e3b7b667edf15cd497c2f710f80b3c29f8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7424
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Niels Sascha Reedijk <niels.reedijk@gmail.com>
BFont::LoadFont can now use an index (0-based) and an optional named-instance (1-based)
to select the font variant from a file.
BFont::LoadFont can also use an index when loading from memory.
Change-Id: I0ce3eb6cc77d32cf43847416561eafe3063ca693
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7402
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Reviewed-by: Máximo Castañeda <antiswen@yahoo.es>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
The Local address will apparently be set by the module->bind() call
in EndpointManager::_Bind(), while the Peer address will be set by
EndpointManager::SetConnection().
This means that if BindChild() fails for some reason, we will now not
be left in a state where the LocalAddress is set but we are unbound.
That could be the cause of #17058, as that panic occurs when
TCPEndpoint::IsBound() returns true, but we have not been added to
the bound hash.
Change-Id: I3121d0d99289d8cf83c7ed3c3e2d413feb6dad70
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7490
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
